Fix/mouseenter mouseleave handlers on i os upd 10 2019 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onLoad: This is the default behaviour, ad requests are done when the player is ready onPlay: New behaviour, Ad requests are only made once playback is initiated. This is necessary as some ad networks consider ad requests to be plays
Readme Update: updates the Readme to highlight an example using es6 i…
Ad play/pause control changes when adContainer is clicked.
Fix: Ad click through would trigger the AdsOnPaused method without pausing the ad playback
fix: fixed error in videojs.ima.min.js
feat: adds a request mode for ad requests
Build for samples at v1.6.2
Updates readme for accurate locale codes
updated dist files for 1.6.3
eunicekokor
reviewed
Oct 3, 2019
| @@ -701,8 +701,10 @@ AdUi.prototype.createAdContainer = function () { | |||
| this.assignControlAttributes(this.adContainerDiv, 'ima-ad-container'); | |||
| this.adContainerDiv.style.position = 'absolute'; | |||
| this.adContainerDiv.style.zIndex = 1111; | |||
| this.adContainerDiv.addEventListener('mouseenter', this.showAdControls.bind(this), false); | |||
| this.adContainerDiv.addEventListener('mouseleave', this.hideAdControls.bind(this), false); | |||
| if (!videojs.browser.IS_IOS) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for custom
fix/mouseenter-mouseleave-handlers-on-iOS.This branch started from original
fix/mouseenter-mouseleave-handlers-on-iOSand rebased onto master (with tag 1.6.3).1 addition --
dist/videojs.ima.min.jsadded as an amendment todist manual update (temp)commit