Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligned eq maxwell #75

Merged
merged 6 commits into from
Aug 9, 2023
Merged

Conversation

DorisReiter
Copy link
Contributor

Updated Maxwell's equations and added boundary conditions.

Added extended Description of the Maxwell equations

Tried to fix MD bugs (without success)
Copy link
Owner

@HelgeGehring HelgeGehring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

Just two little things which I found (see below), could you have a look if I'm right?

Besides that, people start asking about anisotropic permittivities.
We can probably include them directly by just writing $\varepsilon$ and $\mu$ as $\boldsymbol{\varepsilon}$ and $\boldsymbol{\mu}$, right?
(seems like mathbf doesn't work for them but boldsymbol works fine.

docs/math/maxwell.md Outdated Show resolved Hide resolved
docs/math/maxwell.md Outdated Show resolved Hide resolved
docs/math/maxwell.md Show resolved Hide resolved
@DorisReiter
Copy link
Contributor Author

Corrected another typo and changes arguments -> dependencies

@DorisReiter
Copy link
Contributor Author

If we consider anisotropic material, we need to change eps and mu into tensors, not vectors. I think it will not help here, but could be a side comment for future references.
btw. for plasmonic problems (metals), we should also not drop the time dependence, so the most general case is keeping everything, though this might not be the most instructive case.
My suggestion would be to leave it for now and extend it later.

@HelgeGehring HelgeGehring reopened this Aug 9, 2023
@HelgeGehring
Copy link
Owner

Sounds great! I just closed/reopened the PR to run the automatic tests, afterwards I'll merge :)

@HelgeGehring HelgeGehring merged commit ee0c3e2 into HelgeGehring:main Aug 9, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants