-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aligned eq maxwell #75
Aligned eq maxwell #75
Conversation
Added extended Description of the Maxwell equations Tried to fix MD bugs (without success)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
Just two little things which I found (see below), could you have a look if I'm right?
Besides that, people start asking about anisotropic permittivities.
We can probably include them directly by just writing
(seems like mathbf
doesn't work for them but boldsymbol
works fine.
Co-authored-by: Helge Gehring <[email protected]>
Co-authored-by: Helge Gehring <[email protected]>
Corrected another typo and changes arguments -> dependencies |
If we consider anisotropic material, we need to change eps and mu into tensors, not vectors. I think it will not help here, but could be a side comment for future references. |
Sounds great! I just closed/reopened the PR to run the automatic tests, afterwards I'll merge :) |
Updated Maxwell's equations and added boundary conditions.