Skip to content

Commit

Permalink
Fix flaky tests (#657)
Browse files Browse the repository at this point in the history
* fix #654 escape jquery selector

* regression test for #654

* add no notification assertion function

* move obvious screenshots

* preetttier things

* fix ts inclusion error

* test file by file to debug

* embed new data is not that far , 151 days

* fix more tests

* fix mouse coordinate tests

* test different files

* fix movie screenshots

* more easing on the tests

* 2 shards

* remove 60 sec timeout

* test normal views

* use only 1 shard to help reporting

* remove time limitation

* more default screenshots

* focus on image_layer tests

* - Fix show header tests
- Fix previous next image controls tests
- Add new test handles missing tests due to data change

* preetier

* remove only

* an attempt to fix all screenshots of screenshot taking tests

* add broken file for firefox

* ci focus on just screenshot tests

* fix further images

* remove unnec file

* further fixing images

* go fulltest again

* first batch of images to fix form_controls

* focus on form controls

* fix more form-controls

* focus to urlsharing

* ignore damn firefox now for sharedurl test

* issue 647 snapshots

* focus on regression issue647

* preetier

* damn firefox snapshot for issue647

* notifications now can be matched with regexp

* an attempt to fix issue 654 tests with new data

* focus on issue 654

* wait notification to load issue654

* wait even more to notification become visible

* damn preetier

* an attempt to fix mobile screenshots

* fix mobile-safari screenshot

* fix one last time this test

* retry 2 times

* mobile safari sdo-soho image

* an attempt to fix this flaky test

* set screenshot after test fix

* focus on hello_mobile test

* focus on mouse coordinates

* try two times, there shouldn't be anybug

* go fast mode again

* focus on failing test

* increase mismatch ratio for failing image

* all in tests again

* shard number is 5

* an attempt to fix jump with date range tests

* go full test again

* focus on last failed test

* fix last bit of tests and go full test again

* preetier

* jump tests

* add many screenshots as possible

* make retries 0

* more test cases more flakeness fix

* trace on

* an attempt to fix weird flakiness

* trying to move viewport

* trying more

* pull view otherside

* trying to fix with center viewport

* only visible time thing

* add desktop testing back for jump date tests

* fix mobile set observation date flakeness

* enable more tests, go full again, prettier, typescriptfix, expand flakeness fix

* fix flatpickr input changed event

* add max difference ratio to regression test

* fix old test

* remove unnecessary code

* fix preetier
  • Loading branch information
mudhoney authored Jan 27, 2025
1 parent a56728e commit 9206151
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
playwright-e2e-tests:
strategy:
matrix:
shardIndex: [1, 2, 3, 4, 5]
shardIndex: [1,2,3,4,5]
shardTotal: [5]
# If one of the shards fails, continue running the remaining tests
fail-fast: false
Expand Down Expand Up @@ -115,6 +115,7 @@ jobs:
run: |
cd helioviewer.org
npx playwright test --shard=${{matrix.shardIndex}}/${{matrix.shardTotal}}
- uses: actions/upload-artifact@v4
if: always()
with:
Expand Down

0 comments on commit 9206151

Please sign in to comment.