Patch to make dnd work in firefox. #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LeifAndersen I released a new version 2.0.0-beta.2 of this library. Can you check if the issue persists? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This patch is "not" ready to merge, I made this PR as a request for comments/improvements.
It seems like in firefox, svg elements will not have their
onDragStartfunction called. They will, however have theironMouseDownfunction called. This patch adds aonMouseDowncallback, but it also nulls the data stored in the dragging event. Since onMouseDown doesn't seem to let you add information to the drag store, I suspect a shadow store would need to be created in the component's react state.