Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: replace deprecated character which can lead to bug #3911

Closed
wants to merge 1 commit into from

Conversation

12ya
Copy link

@12ya 12ya commented Aug 9, 2024

replace deprecated character which can lead to bug

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima
Copy link
Member

flavioislima commented Aug 9, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@12ya
Copy link
Author

12ya commented Aug 9, 2024

I have read the CLA Document and I hereby sign the CLA

@arielj
Copy link
Collaborator

arielj commented Aug 9, 2024

what do you mean by deprecated character? which bugs can it lead to?

@12ya
Copy link
Author

12ya commented Aug 9, 2024

what do you mean by deprecated character? which bugs can it lead to?

it seems like non-latin character was used, which can lead to "invisible unicode character" bug;
think it's good to change it just in case some people don't have unicode highlighting

@arielj
Copy link
Collaborator

arielj commented Aug 17, 2024

sorry I'm still not sure I understand what's the bug this is fixing, the en-dash character may not be a latin character but it's a valid character and it's different than the hypen character

I don't know if this is fixing a bug or a theoretical problem that some users may experience in their editor? how does the bug look like? what are the conditions for this bug to happen?

@CommandMC
Copy link
Collaborator

Closing this for now as I also don't see the value here. Feel free to re-open if there's an actual issue being resolved. As it stands right now, I would suspect that any moderately up-to-date Electron (which we're using) has no problem with this character

@CommandMC CommandMC closed this Nov 17, 2024
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants