[TECH] Upgrade Axios to latest #3917
Open
+23
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavioislima
requested review from
arielj,
CommandMC,
Etaash-mathamsetty and
imLinguin
flavioislima
added
the
pr:ready-for-review
CommandMC
approved these changes
Aug 11, 2024
| @@ -869,7 +871,7 @@ export async function getBuilds( | |||
| url.searchParams.set('password', password) | |||
| } | |||
|
|
|||
| const headers: AxiosRequestHeaders = {} | |||
| const headers = {} as AxiosRequestHeaders | |||
There was a problem hiding this comment.
This type assertion is incorrect. Most of the time, if you add as T because TS is yelling at you, you're doing something wrong. In this case, {} can't be of type AxiosHeaders (AxiosHeaders is a class with a few methods, which an empty object of course doesn't have)
Axios also accepts a standard Record for headers, which is fine to use here:
Suggested change
| const headers = {} as AxiosRequestHeaders | |
| const headers: Record<string, string> = {} |
| @@ -1265,7 +1267,7 @@ export async function getProductApi( | |||
| url.searchParams.set('expand', expand.join(',')) | |||
| } | |||
|
|
|||
| const headers: AxiosRequestHeaders = {} | |||
| const headers = {} as AxiosRequestHeaders | |||
There was a problem hiding this comment.
Same issue as above here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Axios to latest version and also fix the necessary types and imports
Use the following Checklist if you have changed something on the Backend or Frontend: