Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech] Patch @types/node to restrict our platform type to valid platforms #3927

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

CommandMC
Copy link
Collaborator

process.platform can, under normal circumstances, only ever be win32, darwin, or linux. @types/node can't know this however, so we have to patch it to only make those values possible literal options

Technically this is incorrect (we could have someone run a development version of Heroic on any other platform), but this makes it easier to do checks on the property, or to use it in a switch case / index a Record with it
Somewhat improves the situation of #3908


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Aug 11, 2024
@CommandMC CommandMC self-assigned this Aug 11, 2024
@CommandMC CommandMC requested review from a team, arielj, flavioislima, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team August 11, 2024 20:46
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CommandMC CommandMC merged commit 976b489 into main Nov 18, 2024
9 checks passed
@CommandMC CommandMC deleted the tech/patch-node-platform branch November 18, 2024 14:40
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants