Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Delete runner configurations when resetting heroic #4033

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Etaash-mathamsetty
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty commented Sep 29, 2024

Some people are having issues with nile, and have to manually delete these files, so I propose making heroic do this automatically when it is reset

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Etaash-mathamsetty
Copy link
Member Author

Etaash-mathamsetty commented Sep 29, 2024

I can't run i18n for some reason, if someone else could do it that would be great (nvm got it working)

@arielj
Copy link
Collaborator

arielj commented Sep 29, 2024

I don't think this is a good idea. Users will be confused, then they would have to import every game after logging in?

If this is meant to workaround a problem with nile I think we should solve the problem either with nile or with the integration we have with nile (not sure if the issue is heroic or nile itself).

@Etaash-mathamsetty
Copy link
Member Author

I don't think this is a good idea. Users will be confused, then they would have to import every game after logging in?

If this is meant to workaround a problem with nile I think we should solve the problem either with nile or with the integration we have with nile (not sure if the issue is heroic or nile itself).

It makes users more confused that resetting heroic doesn't actually reset it imo

@arielj
Copy link
Collaborator

arielj commented Oct 2, 2024

I don't think this is a good idea. Users will be confused, then they would have to import every game after logging in?
If this is meant to workaround a problem with nile I think we should solve the problem either with nile or with the integration we have with nile (not sure if the issue is heroic or nile itself).

It makes users more confused that resetting heroic doesn't actually reset it imo

Maybe the solution for that (and I think it would be a good UX improvement in general) is to have a Reset section and allow users to select what to delete. Something like:

RESET
======

- [ ] game settings                       (i)
- [ ] legendary / epic                    (i)
- [ ] nile / amazon                       (i)
- [ ] gogdl / gog                         (i)
- [ ] cache                               (i)
- [ ] something else                      (i)

[ reset ]

Then users can hover the (i) next to each item to understand what that means and decide if they want to reset that particular thing.

@Etaash-mathamsetty
Copy link
Member Author

yea that sounds good, will implement it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants