-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial code for making python_env output an artifact #214
Open
varkha-d-sharma
wants to merge
26
commits into
HewlettPackard:master
Choose a base branch
from
varkha-d-sharma:python_env
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Initial code for making python_env output an artifact #214
varkha-d-sharma
wants to merge
26
commits into
HewlettPackard:master
from
varkha-d-sharma:python_env
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto python_env
…nto python_env
varkha-d-sharma
requested review from
annmary-roy,
rishabhsharma22 and
shreyas-kulkarni09
December 9, 2024 14:16
shreyas-kulkarni09
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is good to merge with a few suggestions for addressing technical debt:
1. Code Modularization
- Break down large functions into smaller, more manageable pieces. For instance, the
run
method inmetadata/push.py
could be refactored into several helper methods for improved clarity and maintainability. - Consider splitting the
cmflib/cmf_server.py
file into multiple smaller files or a dedicated folder structure. For example, methods likelog_model_with_version
andlog_execution_metrics_from_client
could be moved to a separatelogs
file.
2. Type Annotations
- Adding type annotations to function signatures would improve the readability and maintainability of the code, as well as facilitate better type checking.
3. Logging
- Replace
print
statements with proper logging functionality. This would enhance the ability to track and debug issues in a production environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues / Pull Requests
List all related issues and/or pull requests if there are any.
Description
Include a brief summary of the proposed changes.
Environment
What changes are proposed in this pull request?
examples in this repository need to be updated too).
Checklist:
uses Google-style formatting and any other formatting that is supported by mkdocs and plugins this project
uses.