Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bumped the metal client version to 1.5.9 #174

Merged
merged 4 commits into from
Feb 27, 2024
Merged

bumped the metal client version to 1.5.9 #174

merged 4 commits into from
Feb 27, 2024

Conversation

AnuBose
Copy link
Contributor

@AnuBose AnuBose commented Feb 26, 2024

No description provided.

@AnuBose AnuBose requested a review from a team as a code owner February 26, 2024 17:39
@neilgierman
Copy link
Contributor

Wondering if we need to update the version file as well. @chaitra-mylarappachar ?

@chaitra-mylarappachar
Copy link
Contributor

Wondering if we need to update the version file as well. @chaitra-mylarappachar ?

yes, anytime if there is an update to the functionality, we should do this.
This version file is used only when building a standalone provider ( dev purpose, and to host in quake portals ) and not considered when building a published hpegl provider.

@AnuBose
Copy link
Contributor Author

AnuBose commented Feb 26, 2024

Wondering if we need to update the version file as well. @chaitra-mylarappachar ?

yes, anytime if there is an update to the functionality, we should do this. This version file is used only when building a standalone provider ( dev purpose, and to host in quake portals ) and not considered when building a published hpegl provider.

Done.

@AnuBose
Copy link
Contributor Author

AnuBose commented Feb 27, 2024

@neilgierman , @chaitra-mylarappachar , please review

chaitra-mylarappachar
chaitra-mylarappachar reviewed Feb 27, 2024
View reviewed changes
go.mod
@@ -6,7 +6,7 @@ require (
github.com/golangci/golangci-lint v1.55.2
github.com/hashicorp/terraform-plugin-docs v0.18.0
github.com/hashicorp/terraform-plugin-sdk/v2 v2.33.0
github.com/hewlettpackard/hpegl-metal-client v1.5.6
github.com/hewlettpackard/hpegl-metal-client v1.5.8
github.com/hewlettpackard/hpegl-provider-lib v0.0.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest version of client is 1.5.9

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I took 1.5.8 from Slack conversation, will change

chaitra-mylarappachar
chaitra-mylarappachar reviewed Feb 27, 2024
View reviewed changes
version Outdated Show resolved Hide resolved
@AnuBose AnuBose changed the title bumped the metal client version to 1.5.8 bumped the metal client version to 1.5.9 Feb 27, 2024
@AnuBose AnuBose merged commit eb7b7f3 into master Feb 27, 2024
2 checks passed
@AnuBose AnuBose deleted the version-change branch February 27, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilgierman neilgierman neilgierman left review comments

@chaitra-mylarappachar chaitra-mylarappachar chaitra-mylarappachar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnuBose @neilgierman @chaitra-mylarappachar