Added changes to support WWPNs in host. #176
Conversation
internal/resources/resource_host.go
Outdated
| d.Set(hCHAPUser, host.ISCSIConfig.CHAPUser) | ||
| d.Set(hCHAPSecret, host.ISCSIConfig.CHAPSecret) | ||
| d.Set(hInitiatorName, host.ISCSIConfig.InitiatorName) |
There was a problem hiding this comment.
Looks like iscsi information will always be filled in host here regardless protocol. Is it correct that the protocol field was introduced to differentiate the cases, otherwise it will defeat the purpose. Just FYI
There was a problem hiding this comment.
Hi @shi98382, please check this comment from Mike - https://github.com/HewlettPackard/hpegl-metal-terraform-resources/pull/176/files/b7e0b747020293dd264e681bea394e6506632e6d#r1520373211
I have reverted back the protocol check after this discussion.
|
Hi @ron-saito, if you are ok with my response to your suggestion then please let me know. I will merge this PR. |
Co-authored-by: Ron Saito <[email protected]>
|
@mchuang3, @shi98382 and @ron-saito I have accepted Ron's changes and CI build is going on. Once that is done I will update this branch with master and will merge it. |
internal/resources/resource_host.go
Outdated
| @@ -590,6 +600,13 @@ func resourceMetalHostRead(d *schema.ResourceData, meta interface{}) (err error) | |||
| d.Set(hCHAPUser, host.ISCSIConfig.CHAPUser) | |||
| d.Set(hCHAPSecret, host.ISCSIConfig.CHAPSecret) | |||
| d.Set(hInitiatorName, host.ISCSIConfig.InitiatorName) | |||
|
|
|||
| if len(host.WWPNs) > 0 { | |||
There was a problem hiding this comment.
While this was previously discussed, I'm wondering why this is needed (conditional set). without this check, hWWPNs is set to whatever host.WWPNs is
There was a problem hiding this comment.
I just accepted your suggestion on the PR as is. I was also thinking why this is needed. If you are ok I will remove this check.
There was a problem hiding this comment.
Fixed your comment.
Added WWPNs field in host read.