Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host - Ignore lables #183

Closed
wants to merge 11 commits into from
Closed

Conversation

chaitra-mylarappachar
Copy link
Contributor

No description provided.

Copy link
Contributor

@dbozzato81 dbozzato81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. I think we should document (another PR?) the fact that for non IAM token we can completely omit the metal block from the main.tf since we can rely only on the .qjwt file; and for IAM token usage only the gl_token field is required in the metal block since everything else is picked up from the .gltform file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants