Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GLP IAM role and workspace to gltform #117

Merged
merged 1 commit into from
May 30, 2024

Conversation

eamonnotoole
Copy link
Contributor

The Metal team have added support for GLP IAM to their service. This means that glp_role and glp_workspace must be specified in the metal block in the provider stanza. This PR adds the following two entries to gltform

  • glp_workspace
  • glp_role

These entries will be written-out during Metal client initialisation in terraform-provider-hpegl.

Copy link
Collaborator

@dbozzato81 dbozzato81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The Metal team have added support for GLP IAM to their service.  This
means that glp_role and glp_workspace must be specified in the metal
block in the provider stanza.  This PR adds the following two entries to
gltform
- glp_workspace
- glp_role

These entries will be written-out during Metal client initialisation in
terraform-provider-hpegl.

Signed-off-by: Eamonn O'Toole <[email protected]>
@eamonnotoole eamonnotoole force-pushed the gltform-glp-support branch from 76e31ef to e6debac Compare May 30, 2024 16:23
@eamonnotoole eamonnotoole merged commit a5604c9 into main May 30, 2024
4 checks passed
@eamonnotoole eamonnotoole deleted the gltform-glp-support branch May 30, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants