Create new http request on each retry #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AislingHPE
previously approved these changes
Oct 23, 2024
eamonnotoole
force-pushed
the
new-request-on-retry
branch
from
bc71a5f to
50a74a3
Compare
In this PR we change the behaviour in issuertoken to: - create a new http request object on each retry - set Close on each request so that the underlying tcp connection is always closed We do this because we are seeing issues with retries on 502 responses from IAM. Retries don't seem to make any difference, in other words we continue to receive 502 responses on each retry. We fix unit-tests. We also log each retry so that the terraform provider logs will record the retries. Signed-off-by: Eamonn O'Toole <[email protected]>
eamonnotoole
force-pushed
the
new-request-on-retry
branch
from
50a74a3 to
ddd777b
Compare
AislingHPE
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we change the behaviour in issuertoken to:
We do this because we are seeing issues with retries on 502 responses from IAM. Retries don't seem to make any difference, in other words we continue to receive 502 responses on each retry.
We also log each retry so that the terraform provider logs will record the retries.