Skip to content

Commit

Permalink
add log column burst check
Browse files Browse the repository at this point in the history
  • Loading branch information
JFriel committed Aug 10, 2023
1 parent 703eecc commit 06635d1
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 21 deletions.
15 changes: 0 additions & 15 deletions Rdmp.Core/Curation/Data/ExternalDatabaseServer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ public class ExternalDatabaseServer : DatabaseEntity, IExternalDatabaseServer, I
private string _createdByAssembly;
private string _mappedDataPath;
private readonly SelfCertifyingDataAccessPoint _selfCertifyingDataAccessPoint;
private int _maxFreeFormStringLength;
private bool _shouldTruncateFreeFormStrings;
/// <summary>
/// Human readable name for the server e.g. 'My Favourite Logging Database'
/// </summary>
Expand All @@ -48,19 +46,6 @@ public string Name
set => SetField(ref _name, value);
}


public int MaxFreeFormStringLength
{
get => _maxFreeFormStringLength;
set => SetField(ref _maxFreeFormStringLength, value);
}

public bool ShouldtruncateFreeFormStrings
{
get => _shouldTruncateFreeFormStrings;
set => SetField(ref _shouldTruncateFreeFormStrings, value);
}

/// <summary>
/// If the database was created by an RDMP schema (or plugin schema) this will contain the name of the dll which holds the schema e.g. DataQualityEngine.Database and was
/// responsible for creating the database. This determines what roles RDMP lets the database play.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,8 @@ public virtual void OnNotify(object sender, NotifyEventArgs e)
if (DataLoadInfo == null){
StartLogging();
}
//todo have to find out the server we're logging to
// var loggingServer = catalogueRepository.GetDefaultFor(PermissableDefaults.LiveLoggingServer_ID);

// ExternalDatabaseServer loggingServer = CatalogueRepository.Instance.GetDefaultFor(PermissableDefaults.LiveLoggingServer_ID);
int maxMessageLength = 0;//this should be configurable
//todo may want to log first x chars if ifs too big

int maxMessageLength = 64000/ sizeof(Char); //loggingDB text column has max 64kb size, or 65535 chars

switch (e.ProgressEventType)
{
Expand Down

0 comments on commit 06635d1

Please sign in to comment.