fix simple file extractor

CHANGELOG.md

@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Build on and target .Net 9 rather than 8
 - Simplify DB Patching Interface
+- Fix issue with Simple File Extractor pipeline component checking
 
 ## [8.4.2] - 2024-12-18
 

Rdmp.Core/DataExport/DataExtraction/Pipeline/SimpleFileExtractor.cs

@@ -72,17 +72,6 @@ public override void Check(ICheckNotifier notifier)
             notifier.OnCheckPerformed(new CheckEventArgs(
                 $"PerPatient is false but Pattern {Pattern} contains token $p.  This token will never be matched in MoveAll mode",
                 CheckResult.Fail));
-
-        try
-        {
-            notifier.OnCheckPerformed(new CheckEventArgs($"Output path is:{GetDestinationDirectory()}",
-                CheckResult.Success));
-        }
-        catch (Exception ex)
-        {
-            throw new Exception(
-                "Unable to to determine output directory from 'OutputDirectoryName'.  Perhaps pattern is bad", ex);
-        }
     }
 
     protected override void MoveFiles(ExtractGlobalsCommand command, IDataLoadEventListener listener,
@@ -124,7 +113,7 @@ public DirectoryInfo GetDestinationDirectory()
         if (path.Contains("$p")) path = path.Replace("$p", _command.Project.ExtractionDirectory);
         if (path.Contains("$n")) path = path.Replace("$n", _command.Project.ProjectNumber.ToString());
 
-        if (path.Contains("$c"))
+        if (path.Contains("$c") )
             path = path.Replace("$c",
                 new ExtractionDirectory(_command.Project.ExtractionDirectory, _command.Configuration)
                     .ExtractionDirectoryInfo.FullName);