fix up tests

HicServices · Oct 29, 2024 · 4fe2f66 · 4fe2f66
1 parent 08b2ca1
commit 4fe2f66
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 4 deletions.
diff --git a/Rdmp.Core/Curation/Data/Overview/OverviewModel.cs b/Rdmp.Core/Curation/Data/Overview/OverviewModel.cs
@@ -42,7 +42,10 @@ public OverviewModel(IBasicActivateItems activator, ICatalogue catalogue)
     {
         _activator = activator;
         _catalogue = catalogue;
-        Regen("");
+        if (catalogue != null)
+        {
+            Regen("");
+        }
     }
 
     public void Regen(string whereClause)
@@ -55,6 +58,7 @@ public void Regen(string whereClause)
             column = _catalogue.CatalogueItems.FirstOrDefault();
             hasExtractionIdentifier = false;
         }
+        if (column is null) return;
         var discoveredColumn = column.ColumnInfo.Discover(DataAccessContext.InternalDataProcessing);
         var server = discoveredColumn.Table.Database.Server;
         using var con = server.GetConnection();

diff --git a/Rdmp.UI.Tests/ForEachUITests.cs b/Rdmp.UI.Tests/ForEachUITests.cs
@@ -6,6 +6,8 @@
 
 using NUnit.Framework;
 using Rdmp.Core.CommandExecution.AtomicCommands;
+using Rdmp.Core.Curation.Data;
+using Rdmp.UI.Overview;
 using Tests.Common;
 
 namespace Rdmp.UI.Tests;
@@ -29,4 +31,14 @@ public void ForEachUI_Test_GetTabName()
             });
         });
     }
+
+    [Test, UITimeout(20000)]
+    public void Test_ViewCatalogueOverviewUI_Constructor()
+    {
+        var o = WhenIHaveA<Catalogue>();
+        var ui = AndLaunch<ViewCatalogueOverviewUI>(o);
+        //Assert.IsNotNull(ui);
+        //AssertNoErrors(ExpectedErrorType.Fatal);
+        //AssertNoErrors(ExpectedErrorType.KilledForm);
+    }
 }
diff --git a/Rdmp.UI/Overview/ViewCatalogueOverviewUI.cs b/Rdmp.UI/Overview/ViewCatalogueOverviewUI.cs
@@ -77,10 +77,17 @@ private void UpdateCatalogueData()
         {
             lblLatestExtraction.Text = "Catalogue has not been extracted";
         }
-        var syntaxHelper = _catalogue.GetDistinctLiveDatabaseServer(DataAccessContext.InternalDataProcessing, false).GetQuerySyntaxHelper();
-        var dateTypeString = syntaxHelper.TypeTranslater.GetSQLDBTypeForCSharpType(new TypeGuesser.DatabaseTypeRequest(typeof(DateTime)));
-
+        try
+        {
+            var syntaxHelper = _catalogue.GetDistinctLiveDatabaseServer(DataAccessContext.InternalDataProcessing, false)?.GetQuerySyntaxHelper();
+            var dateTypeString = syntaxHelper.TypeTranslater.GetSQLDBTypeForCSharpType(new TypeGuesser.DatabaseTypeRequest(typeof(DateTime)));
+
         _dateColumns = _catalogue.CatalogueItems.Where(ci => ci.ColumnInfo.Data_type == dateTypeString).ToList();
+        }
+        catch
+        {
+            return;
+        }
         cbTimeColumns.Items.Clear();
         cbTimeColumns.Items.AddRange(_dateColumns.ToArray());
         var pks = _dateColumns.Where(ci => ci.ColumnInfo.IsPrimaryKey).ToList();