Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B06148 UI tweaks - rename bandwidth to data transfer #71

Closed
wants to merge 2 commits into from
Closed

B06148 UI tweaks - rename bandwidth to data transfer #71

wants to merge 2 commits into from

Conversation

Paterick
Copy link
Collaborator

@Paterick Paterick commented Oct 16, 2023 •
edited
Loading

Link to ticket in agility

  • Rename hApp card bandwidth field to data transfer
  • Adjust underlying data to use data_transfer instead of bandwidth
  • Hide storage usage stat (temporary)

image

JettTech
JettTech reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@JettTech JettTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, but might need a bit more work if we decide to keep the data-transfer reaming only to the UI. Let's revisit this following PL.

@Paterick
Copy link
Collaborator Author

Closing this PR per our conversation in stand-up this morning. Abandoning the back-end changes and only changing the text in the UI.

@Paterick Paterick closed this Oct 17, 2023
@Paterick Paterick deleted the b06148-ui-tweaks branch October 17, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JettTech JettTech JettTech left review comments

@mateuszRybczonek mateuszRybczonek Awaiting requested review from mateuszRybczonek mateuszRybczonek is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Paterick @JettTech