Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/enable details link #73

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Feature/enable details link #73

merged 2 commits into from
Oct 23, 2023

Conversation

mateuszRybczonek
Copy link
Collaborator

@mateuszRybczonek mateuszRybczonek commented Oct 23, 2023 •
edited
Loading

This PR enables the "Details Link" on HAppCard by passing areDetailsAvailable props. Then the component emits an details-link-click event when clicked.

Screenshot 2023-10-23 at 22 08 15

@mateuszRybczonek mateuszRybczonek self-assigned this Oct 23, 2023
Paterick
Paterick approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@Paterick Paterick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks. I needed this for cloud console but couldn't think of how to do it w/o breaking host console.

@mateuszRybczonek mateuszRybczonek merged commit ca3e781 into develop Oct 23, 2023
1 check passed
@mateuszRybczonek mateuszRybczonek deleted the feature/enable-details-link branch October 23, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paterick Paterick Paterick approved these changes

Assignees

@mateuszRybczonek mateuszRybczonek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateuszRybczonek @Paterick