Skip to content

Commit

Permalink
nitpicking icons
Browse files Browse the repository at this point in the history
  • Loading branch information
sphinxrave committed Oct 27, 2024
1 parent 7681c1c commit 39924b6
Show file tree
Hide file tree
Showing 10 changed files with 42 additions and 43 deletions.
2 changes: 1 addition & 1 deletion packages/react/grep-icons.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def extract_icons(directory):
content = f.read()
matches = re.findall(pattern, content)
for match in matches:
icons[match].add(file_path)
icons[match].add(file_path.replace("\\", "/"))

return icons

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -178,13 +178,14 @@ export const FormChannelPicker = ({
control={control}
name={name}
render={({ field }) => (
<FormItem>
<FormLabel>{label}</FormLabel>
<FormItem className="flex flex-col space-y-2">
<FormLabel className="leading-normal">{label}</FormLabel>
<FormControl>
<ChannelPicker
{...props}
value={field.value}
onSelect={({ id }) => field.onChange(id)}
type="vtuber"
/>
</FormControl>
<FormMessage />
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/header/header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export function Header({ id }: HeaderProps) {
className="ml-2 text-lg text-base-10"
onClick={() => setIsSearching(false)}
>
<div className="i-heroicons:x-mark h-8 w-8" />
<div className="i-lucide:x h-8 w-8" />
</Button>
</div>
) : (
Expand Down
9 changes: 5 additions & 4 deletions packages/react/src/components/playlist/IndividualPlaylist.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export default function IndividualPlaylist({ playlist }: Props) {
variant="ghost"
onClick={() => setRenaming((prev) => !prev)}
>
<span className="i-heroicons:pencil-solid" />
<span className="i-lucide:edit-3" />
</Button>
) : null}
</div>
Expand Down Expand Up @@ -142,15 +142,16 @@ export default function IndividualPlaylist({ playlist }: Props) {
}
>
{/* todo: intl this */}
<span className="i-lucide:save" /> Save Changes
<span className="i-fluent:save-20-filled" /> Save Changes
</Button>
{editedPlaylist !== null ? (
<Button
size="icon"
variant="ghost"
title="Reset"
onClick={() => setEditedPlaylist(null)}
>
<span className="i-heroicons:arrow-path-solid" />
<span className="i-fluent:arrow-reset-20-filled" />
</Button>
) : null}
</>
Expand All @@ -177,7 +178,7 @@ export default function IndividualPlaylist({ playlist }: Props) {
variant="ghost"
onClick={() => deleteVideo(index)}
>
<span className="i-heroicons:x-mark" />
<span className="i-lucide:x" />
</Button>
<Button
size="icon"
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/sidebar/sidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export function Sidebar() {
<div className="flex grow" />
<Button
variant="ghost"
className="i-heroicons:x-mark p-4 md:hidden"
className="i-lucide:x p-4 md:hidden"
onClick={toggle}
/>
</div>
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/tldex/TLChat.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export function TLChat({ videoId }: TLChatProps) {
followOutput="smooth"
startReached={() => chatDB.loadMessages({ partial: 30 })}
data={processedMessages}
itemContent={(idx, { key, ...message }, ctx) => (
itemContent={(_, { key, ...message }) => (
<TLChatMessage {...message} key={key} />
)}
/>
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/video/MainVideoListing.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export function MainVideoListing({
cn(
"grid w-full gap-4 px-4 py-2 @container md:px-8",
{
"grid-cols-1": size === "list",
"grid-cols-1 gap-1": size === "list",
"grid-cols-[repeat(auto-fill,minmax(340px,1fr))]": size === "lg",
"grid-cols-[repeat(auto-fill,minmax(220px,1fr))]": size === "md",
"grid-cols-[repeat(auto-fill,minmax(180px,1fr))]": size === "sm",
Expand Down
55 changes: 26 additions & 29 deletions packages/react/src/components/video/VideoCardPlaceholder.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,13 @@ export default function VideoCardPlaceholder({
</div>
</div>
<div className="grid gap-4 px-4 pb-4">
<Button size="lg" variant="default" className="" asChild>
<Button size="lg" variant="default" className="h-12 py-4" asChild>
<a href={video.link} target="_blank" rel="noopener noreferrer">
<div
className={
video.placeholderType === "scheduled-yt-stream"
? "i-logos:youtube-icon mr-2"
: "i-heroicons:arrow-top-right-on-square mr-2"
? "i-logos:youtube-icon mr-1"
: "i-heroicons:arrow-top-right-on-square mr-1"
}
/>
{video.placeholderType === "scheduled-yt-stream"
Expand All @@ -88,28 +88,25 @@ export default function VideoCardPlaceholder({
</a>
</Button>
<div className="flex flex-row">
<div className="grow">
<p>{t("component.placeholderVideo.creditTitleText")}</p>
{video.credits?.discord && (
<p>
{t("component.placeholderVideo.discordCredit", {
user: video.credits.discord.user,
guild: (
<strong>
<a
href={`https://discord.gg/${video.credits.discord.link}`}
className="inline-block"
>
<div className="i-logos:discord-icon mr-1 inline-block" />
{video.credits.discord.guildName}
</a>
</strong>
),
})}
</p>
)}
<div className="grow text-sm text-muted">
{t("component.placeholderVideo.creditTitleText")}{" "}
{video.credits?.discord &&
t("component.placeholderVideo.discordCredit", {
user: video.credits.discord.user,
guild: (
<strong>
<a
href={`https://discord.gg/${video.credits.discord.link}`}
className="inline-block"
>
<div className="i-logos:discord-icon mr-1 inline-block" />
{video.credits.discord.guildName}
</a>
</strong>
),
})}
{video.credits?.datasource && (
<p>
<span>
{t("component.placeholderVideo.datasourceCredit", {
0: video.credits.datasource.name,
})}
Expand All @@ -119,10 +116,10 @@ export default function VideoCardPlaceholder({
{video.credits.datasource.link}
</a>
</strong>
</p>
</span>
)}
{video.credits?.bot && (
<p>
<span>
{t("component.placeholderVideo.botCredit", {
0: video.credits.bot.name,
1: video.credits.bot.user,
Expand All @@ -133,14 +130,14 @@ export default function VideoCardPlaceholder({
{video.credits.bot.link}
</a>
</strong>
</p>
</span>
)}
{video.credits?.editor && (
<p>
<span>
{t("component.placeholderVideo.editorCredit", {
0: video.credits.editor.name,
})}
</p>
</span>
)}
</div>
{user && user.role !== "user" && (
Expand Down
4 changes: 2 additions & 2 deletions packages/react/src/routes/about/general.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export const QuickLinks = () => {
className:
"border-blue-11 hover:bg-blue-4 hover:border-blue-11 text-blue-11",
href: "https://twitter.com/holodex",
icon: "i-lucide:twitter",
icon: "i-tabler:brand-twitter",
label: t("about.quicklink.twitter"),
},
{
Expand All @@ -151,7 +151,7 @@ export const QuickLinks = () => {
className:
"border-orange-10 hover:bg-orange-4 hover:border-orange-10 text-orange-10",
href: "https://docs.holodex.net/",
icon: "i-lucide:file-code",
icon: "i-mdi:cloud-json",
label: t("about.quicklink.apiDocs"),
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/routes/settings/content.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export function SettingsContentPreferences() {
onCheckedChange: () => setHidePlaceholder(!hidePlaceholder),
label: t("views.settings.hidePlaceholderStreams"),
variant: "icon" as const,
icon: "i-lucide:calendar",
icon: "i-tabler:calendar-event",
},
{
id: "filter_dead_streams",
Expand Down

0 comments on commit 39924b6

Please sign in to comment.