Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump more files to Sorbet typed: strict #18354

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bump more files to Sorbet typed: strict #18354

wants to merge 2 commits into from

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Sep 18, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @issyl0! A few style suggestions, none blocking.

Library/Homebrew/cask/migrator.rb Outdated Show resolved Hide resolved
Library/Homebrew/help.rb Outdated Show resolved Hide resolved
Library/Homebrew/help.rb Outdated Show resolved Hide resolved
Library/Homebrew/help.rb Outdated Show resolved Hide resolved
Library/Homebrew/help.rb Outdated Show resolved Hide resolved
Library/Homebrew/help.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_cellar_checks.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_cellar_checks.rb Outdated Show resolved Hide resolved
Co-authored-by: Mike McQuaid <[email protected]>
Co-authored-by: Carlo Cabrera <[email protected]>
@@ -191,6 +191,7 @@ def check_elisp_root(share, name)
EOS
end

sig { params(lib: Pathname, deps: T::Array[Formula]).returns(T.nilable(String)) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sig { params(lib: Pathname, deps: T::Array[Formula]).returns(T.nilable(String)) }
sig { params(lib: Pathname, deps: Dependencies).returns(T.nilable(String)) }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants