-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cask/cask: pass args when initalising methods #18438
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bevanjkay
force-pushed
the
extract_plist_url_fix
branch
from
September 27, 2024 06:57
1df973a
to
63a7847
Compare
MikeMcQuaid
approved these changes
Sep 27, 2024
bevanjkay
force-pushed
the
extract_plist_url_fix
branch
from
October 7, 2024 11:05
63a7847
to
7e61774
Compare
bevanjkay
changed the title
livecheck/strategy/extract_plist: fix extract_plist
cask/cask: pass args when initalising methods
Oct 7, 2024
url
bevanjkay
force-pushed
the
extract_plist_url_fix
branch
from
October 7, 2024 11:06
7e61774
to
1b57dd3
Compare
bevanjkay
force-pushed
the
extract_plist_url_fix
branch
3 times, most recently
from
October 9, 2024 02:35
472a972
to
3cd4383
Compare
I had added a test so that we can catch this regression in future, as I don't think it's the first time we've had some issues here. |
reitermarkus
reviewed
Oct 9, 2024
Library/Homebrew/test/support/fixtures/cask/Casks/livecheck/livecheck-extract-plist.rb
Outdated
Show resolved
Hide resolved
reitermarkus
approved these changes
Oct 9, 2024
bevanjkay
force-pushed
the
extract_plist_url_fix
branch
2 times, most recently
from
October 9, 2024 23:39
4ac277e
to
3b130bc
Compare
bevanjkay
force-pushed
the
extract_plist_url_fix
branch
from
October 9, 2024 23:41
3b130bc
to
8b33aa0
Compare
Thanks @bevanjkay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?When a custom
url
is passed to the ExtractPlist livecheck strategy, we were creating a copy of the cask and replacing theurl
. This was being parsed as a block, which was causing a deprecation error now thaturl do
blocks are deprecated.This PR instead creates a minimal copy of the cask and passes it to CaskLoader as content instead of copying the entire cask.