Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cask/cask: pass args when initalising methods #18438

Merged
merged 5 commits into from
Oct 13, 2024

Conversation

bevanjkay
Copy link
Member

@bevanjkay bevanjkay commented Sep 27, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

When a custom url is passed to the ExtractPlist livecheck strategy, we were creating a copy of the cask and replacing the url. This was being parsed as a block, which was causing a deprecation error now that url do blocks are deprecated.

This PR instead creates a minimal copy of the cask and passes it to CaskLoader as content instead of copying the entire cask.

@bevanjkay bevanjkay changed the title livecheck/strategy/extract_plist: fix extract_plist url cask/cask: pass args when initalising methods Oct 7, 2024
@bevanjkay bevanjkay force-pushed the extract_plist_url_fix branch 3 times, most recently from 472a972 to 3cd4383 Compare October 9, 2024 02:35
@bevanjkay
Copy link
Member Author

I had added a test so that we can catch this regression in future, as I don't think it's the first time we've had some issues here.

@bevanjkay bevanjkay force-pushed the extract_plist_url_fix branch 2 times, most recently from 4ac277e to 3b130bc Compare October 9, 2024 23:39
@MikeMcQuaid MikeMcQuaid merged commit a25a541 into Homebrew:master Oct 13, 2024
27 checks passed
@MikeMcQuaid
Copy link
Member

Thanks @bevanjkay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants