github/workflows: use macos-15 GitHub Actions runners. #18462
+13
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MikeMcQuaid
commented
Sep 30, 2024
MikeMcQuaid
commented
- Let's use this instead of macOS 14/latest when possible.
- Keep around macOS 13 to ensure we're still testing x86_64.
- Let's use this instead of macOS 14/latest when possible. - Keep around macOS 13 to ensure we're still testing x86_64.
Blocked until GitHub sorts this out I guess. |
auto-merge was automatically disabled
September 30, 2024 08:49
Pull request was converted to draft
ZhongRuoyu
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
I suppose this will conflict with #18395 (which I forgot to merge). Can we 
that first if you don't mind?
|
@ZhongRuoyu Sure, done! |
dduugg
reviewed
Sep 30, 2024
| @@ -84,7 +84,7 @@ def run | |||
| test-bot: | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-22.04, macos-13, macos-14] | |||
| os: [ubuntu-22.04, macos-13, macos-15] | |||
There was a problem hiding this comment.
Why not:
Suggested change
| os: [ubuntu-22.04, macos-13, macos-15] | |
| os: [ubuntu-22.04, macos-14, macos-15] |
There was a problem hiding this comment.
macOS 13 is x86_64. macOS 14 and 15 are arm64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.