Support link: :overwrite option
#1455
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set `link: :overwrite` per formula to use `brew link --overwrite` to force linking and overwrite all conflicting files - use the linked? and keg_only? predicates available from Formula - `--force` should only be passed when it's keg-only - check linked/unlinked state to avoid re-calling `brew link`\`brew unlink`
MikeMcQuaid
reviewed
Sep 30, 2024
| # 'brew install --with-rmtp', 'brew services restart' on version changes | ||
| brew "denji/nginx/nginx-full", args: ["with-rmtp"], restart_service: :changed | ||
| # 'brew install --with-rmtp', 'brew link --overwrite', 'brew services restart' on version changes | ||
| brew "denji/nginx/nginx-full", link: :overwrite, args: ["with-rmtp"], restart_service: :changed |
There was a problem hiding this comment.
Not sure about this DSL; having true/false/:overwrite as valid values is a bit confusing. Thoughts about link_overwrite: true instead?
| end | ||
| end | ||
|
|
||
| if cmd |
There was a problem hiding this comment.
Suggested change
| if cmd | |
| if cmd.present? |
| when true | ||
| unless linked_and_keg_only? | ||
| puts "Force-linking #{@name} formula." if verbose |
There was a problem hiding this comment.
This seems like a behaviour, maybe messaging, change? Can you detail the expected changes in behaviour/messaging? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link: :overwriteper formulabrew link --overwriteto force linking and overwrite all conflicting fileslinked?andkeg_only?predicates available fromFormula--forceshould only be passed when it's keg-onlybrew link/brew unlinkCloses #1062
Resolves #1116 (comment), #1116 (comment)