Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-vscode and HOMEBREW_BUNDLE_DUMP_NO_VSCODE #1459

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Oct 2, 2024

This allows excluding VSCode output from brew bundle dump with a flag or environment variable.

While we're here

  • generally refactor how we handle command arguments so this logic is pushed into cmd/bundle and made more consistent
  • fix early RSpec failure due to an unstubbed exec call
  • refactor some specs to be more idiomatic

Fixes #1209
Fixes #1212
Fixes #1456

This allows excluding VSCode output from `brew bundle dump` with a
flag or environment variable.

While we're here
- generally refactor how we handle command arguments so this logic is
  pushed into `cmd/bundle` and made more consistent
- fix early RSpec failure due to an unstubbed `exec` call
- refactor some specs to be more idiomatic
@MikeMcQuaid MikeMcQuaid merged commit e91a62c into master Oct 2, 2024
2 checks passed
@MikeMcQuaid MikeMcQuaid deleted the vscode_list_dump branch October 2, 2024 12:25
@MikeMcQuaid
Copy link
Member Author

Thanks @jacobbednarz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants