Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

update font Koruri #253

Closed
wants to merge 1 commit into from
Closed

update font Koruri #253

wants to merge 1 commit into from

Conversation

unasuke
Copy link
Contributor

@unasuke unasuke commented Nov 15, 2014

The issue #248 is old style. Sorry.

vitorgalvao pushed a commit that referenced this pull request Nov 15, 2014
@vitorgalvao vitorgalvao mentioned this pull request Nov 15, 2014
@vitorgalvao
Copy link
Contributor

Thank you for the contribution. It will be merged in a different pull request due to some simple recommended alterations. Your contribution is still included (and still credited to you), with the appropriate modifications, when applicable.

Changes:

  • Facilitated future updates.
  • Added a small note pointing out the download host is officially different from the project’s home.
  • Added version and sha256, since url is now versioned.
  • url had invalid (for what we require) sourceforge format.

vitorgalvao pushed a commit that referenced this pull request Nov 15, 2014
@unasuke
Copy link
Contributor Author

unasuke commented Nov 15, 2014

Thank you for comment.
I'm really happy to you edited my pull request.
Sorry for my immaturity code.

@vitorgalvao
Copy link
Contributor

Don’t worry about it. Only one change was required (but the necessity isn’t very well documented yet), and just a few of the changes are recommended. The rest were just small (yet undocumented, as well) nice-to-have features.

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants