Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freetube: add requires_rosetta, quit and fixups #167117

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

toobuntu
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

  • Add caveat: requires_rosetta
  • Add depends_on: macos >= high_sierra
  • Add uninstall: quit
  • Modify zap: include extra path

  - Add caveat: requires_rosetta
  - Add depends_on: macos >= high_sierra
  - Add uninstall: quit
  - Modify zap: include extra path
@toobuntu
Copy link
Contributor Author

The motivation for this is FreeTubeApp/FreeTube#2786 (comment):

Basically it's a lot easier for everyone to just run the x64 build of FreeTube through Rosetta 2.

While there, audit complained about a missing minimum OS version, createzap found an additional path, and I added uninstall quit.

@bevanjkay bevanjkay merged commit 8cf949e into Homebrew:master Feb 20, 2024
7 checks passed
PikachuEXE added a commit to PikachuEXE/homebrew-FreeTube that referenced this pull request Feb 20, 2024
@toobuntu toobuntu deleted the requires-rosetta/freetube branch February 20, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants