Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert shotcut to 24.08.29 #186968

Closed
wants to merge 1 commit into from

Conversation

tonejito
Copy link

@tonejito tonejito commented Sep 30, 2024

Revert the changes from #185387 to bump back shortcut from 24.09.13 to 24.08.29.

The shotcut software has an issue on the 24.09.13 release and the DMG binary does not have that version number:

The DMG binary should be shotcut-macos-240913.dmg, but it was overwritten as shotcut-macos-240919.dmg (240913 was overwritten to 240919)

The 24.09.19 version is currently marked as pre-release, so the checks fail because it is not "stable".

This issue has been reported to the upstream repository, but the maintainer stated that it might get fixed in homebrew, rather than upstream.

There were efforts to manually patch the Cask file to allow for this situation to be handled. However, the PRs were closed for a variety of reasons and the CI checks were not passing.

This PR is an attempt to revert the changes created on #185387 and fall back to the last version that passed the checks.

This might not be he ideal solution, but we can create another PR to update to the next stable branch where the version numbers match after things have settled.


Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:


Fixes:

Revert the changes from Homebrew#185387 to bump back shortcut from `24.09.13` to `24.08.29`.
@khipp khipp mentioned this pull request Sep 30, 2024
8 tasks
@khipp khipp added the superseded PR was replaced by another PR label Oct 4, 2024
@khipp
Copy link
Member

khipp commented Oct 4, 2024

Superseded by #187021.

@khipp khipp closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
superseded PR was replaced by another PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants