Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grantlee: switch to Qt6 #118217

Closed
wants to merge 1 commit into from
Closed

grantlee: switch to Qt6 #118217

wants to merge 1 commit into from

Conversation

yurikoles
Copy link
Contributor

@yurikoles yurikoles commented Dec 15, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@yurikoles
Copy link
Contributor Author

yurikoles commented Dec 15, 2022

Please add label help wanted, I'm unsure how to pass test if qt is installed.

I check by linked?

@yurikoles
Copy link
Contributor Author

yurikoles commented Dec 15, 2022

grantlee-qt5 formula is discussable and may be dropped.

@yurikoles yurikoles mentioned this pull request Dec 15, 2022
@yurikoles yurikoles marked this pull request as ready for review December 15, 2022 13:43
@yurikoles
Copy link
Contributor Author

yurikoles commented Dec 15, 2022

It seems that Linux runner is building qt from source, it has no bottle. :(

@chenrui333 chenrui333 changed the title grantlee qt5, qt6 grantlee: switch to qt6, grantlee-qt5 5.3.1 (new formula) Dec 15, 2022
@chenrui333 chenrui333 added the new formula PR adds a new formula to Homebrew/homebrew-core label Dec 15, 2022
@p-linnane p-linnane mentioned this pull request Dec 16, 2022
@chenrui333
Copy link
Member

looks like no space on the linux build

/tmp/qt-20221215-123200-1tynvv7/qt-everywhere-src-6.4.1/qtscxml/src/statemachine/qstatemachine.h:164:2: fatal error: cannot write PCH file: No space left on device
  164 | };
      |  ^

@chenrui333 chenrui333 added the linux Linux is specifically affected label Dec 17, 2022
@SMillerDev
Copy link
Member

I'd say we can drop the qt5 version since that qt isn't actively developed anymore.

@yurikoles
Copy link
Contributor Author

Forgot to mention upstream PR: steveire/grantlee#88

Signed-off-by: Yurii Kolesnykov <[email protected]>
@BrewTestBot BrewTestBot removed the new formula PR adds a new formula to Homebrew/homebrew-core label Dec 18, 2022
@yurikoles yurikoles changed the title grantlee: switch to qt6, grantlee-qt5 5.3.1 (new formula) grantlee: switch to Qt6 Dec 18, 2022
@yurikoles
Copy link
Contributor Author

I dropped grantlee-qt5.

@BrewTestBot
Copy link
Member

:shipit: @SMillerDev has triggered a merge.

@yurikoles yurikoles deleted the grantlee branch December 19, 2022 10:24
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
linux Linux is specifically affected outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants