Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kibana 5.4.0 #13231

Closed
wants to merge 2 commits into from
Closed

kibana 5.4.0 #13231

wants to merge 2 commits into from

Conversation

jasontedor
Copy link
Contributor

This pull request updates the Kibana version from 5.3.2 to 5.4.0.

@ilovezfs
Copy link
Contributor

ilovezfs commented May 4, 2017

@jasontedor I think kibana is failing due to angular-translate/grunt-angular-translate#84

Should we pass --force?

Copy link
Contributor Author

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment.

@@ -45,7 +45,7 @@ def install
ENV.prepend_path "PATH", prefix/"libexec/node/bin"
Pathname.new("#{ENV["HOME"]}/.npmrc").write Language::Node.npm_cache_config
system "npm", "install", "--verbose"
system "npm", "run", "build", "--", "--release", "--skip-os-packages", "--skip-archives"
system "npm", "run", "build", "--", "--release", "--skip-os-packages", "--skip-archives", "--force"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had time to dig into what is going on here, but I don't think we should do this, it's not needed when we build the release bits.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasontedor OK, I reverted it

@ilovezfs
Copy link
Contributor

ilovezfs commented May 5, 2017

The failure on Sierra looks like a parallelization problem.
https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/851/version=sierra/

@stale stale bot added the stale No recent activity label May 26, 2017
@stale
Copy link

stale bot commented May 26, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@ilovezfs
Copy link
Contributor

@BrewTestBot test this please

@stale stale bot removed the stale No recent activity label May 27, 2017
@ilovezfs ilovezfs closed this in f297a9b May 27, 2017
@ilovezfs
Copy link
Contributor

@jasontedor Thanks for the pull request. Shipped! It looks like the build issue spontaneously resolved probably due to a fix in one of the node dependencies.

@jasontedor
Copy link
Contributor Author

@ilovezfs Awesome, thank you!

@jasontedor jasontedor deleted the kibana-5.4.0 branch May 27, 2017 13:16
@ilovezfs
Copy link
Contributor

You're welcome!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants