-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kibana 5.4.0 #13231
kibana 5.4.0 #13231
Conversation
@jasontedor I think kibana is failing due to angular-translate/grunt-angular-translate#84 Should we pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment.
Formula/kibana.rb
Outdated
@@ -45,7 +45,7 @@ def install | |||
ENV.prepend_path "PATH", prefix/"libexec/node/bin" | |||
Pathname.new("#{ENV["HOME"]}/.npmrc").write Language::Node.npm_cache_config | |||
system "npm", "install", "--verbose" | |||
system "npm", "run", "build", "--", "--release", "--skip-os-packages", "--skip-archives" | |||
system "npm", "run", "build", "--", "--release", "--skip-os-packages", "--skip-archives", "--force" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had time to dig into what is going on here, but I don't think we should do this, it's not needed when we build the release bits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasontedor OK, I reverted it
The failure on Sierra looks like a parallelization problem. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
@BrewTestBot test this please |
@jasontedor Thanks for the pull request. Shipped! It looks like the build issue spontaneously resolved probably due to a fix in one of the node dependencies. |
@ilovezfs Awesome, thank you! |
You're welcome! |
This pull request updates the Kibana version from 5.3.2 to 5.4.0.