Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
We make the GlobalCollector mutable.
We give the Collector a sendingThread which can have an Emitter. When the Collector collects enough events, it forwards a batch of them to the sendingThread. If the sendingThread has an Emitter, it attempts to send its current batch on that Emitter.
On shutdown, contexts get canceled, background threads get waited on, and then an accumulated un-emitted events are returned from the Collector, same as previously.
SELECT ... INTO OUTFILE ...
testsThis PR adds BATS tests for a
SELECT ... INTO OUTFILE ...
feature we're adding.Companion pr: support
SELECT ... INTO OUTFILE/DUMPFILE ...
dolthub/go-mysql-server#2317This adds the necessary scaffolding to support the new
ExtendedType
interface within GMS. This interface is primarily used by DoltgreSQL to implement PostgreSQL types.Related PRs:
Three new system variables to configure stats auto refresh, one for turning on, one for a timer of how often to check whether stats are fresh, and a third for a freshness threshold to trigger writing new stats. The system variables are global, and will apply to all databases in a server context. Adding or dropping databases, tables, and indexes are reflected by the statistics provider.
Statistic updates now funnel through a process where we preserve buckets for pre-existing chunks and create new buckets specifically for new chunk ordinals. The auto-refresh threshold compares the number of new and deleted buckets compared the the existing bucket count. So inserts, updates, and deletes all create new chunks or delete chunks relative to the previously saved statistics, and the fraction of (new+deleted)/previous count is compared against the threshold.
TODO:
other:
go-mysql-server
We originally supported one type of procedure handler,
NOT FOUND
, which explicitly checked for an error when fetching from a cursor io.EOFs. The implementation for that handler would walk the entire BEGIN/END scope stack inside the Fetch call looking for a handler, execute the handler body, and then embed the scope height into a special return error. The error walked back up the callstack looking for the BEGIN/END block embedded in the error message.This PR:
FetchEOF
, because each scope will explicitly compare its handlers to errors raised during execution within its BEGIN/END bounds. (FetchEOF
is important because we differentiate between 3 different types ofio.EOF
in procedure loops).SQLEXCEPTION
signal handling, which will trigger for any error type (other than io.EOF) that bubbles up during aBeginEndIter
's execution.re: Add support for handlers dolthub/dolt#7454
Another thing I noticed is that some of our tests return nil for empty stored procedures when mysql returns
ERROR 1329 (02000): No data - zero rows fetched, selected, or processed
. https://github.com/dolthub/dolt/issues/newModifies the
InjectedExpr
handling to support additional expressions, such as those requiring name resolution.Related PRs:
SELECT ... INTO OUTFILE/DUMPFILE ...
This adds support for MySQL's
SELECT ... INTO OUTFILE/DUMPFILE ...
feature.It is the complement to
LOAD DATA
. There is noLOCAL
option, so files created using this feature are on the server.This PR adds a custom TestSuite for testing these files, as it needs to write, read, and delete files.
syntax: add syntax support for
SELECT ... INTO OUTFILE ...
options dolthub/vitess#311fixes Add support for "SELECT INTO" for files dolthub/dolt#7453
auto_increment
columns to be dropped when an appropriate index existsMySQL allows a primary key with an
auto_increment
column to be dropped as long as there is a secondary index that includes theauto_increment
column as the first column in the index. (MySQL Reference)This PR also enables dropping a primary key by referencing it by it's ID (
PRIMARY
), in order to match MySQL's behavior, e.g.This adds the
ExtendedType
interface, which is used within DoltgreSQL to implement PostgreSQL types, as well as in Dolt to properly handle the new type and value serialization.Related PRs:
Fixes regression introduced by 9b9301f8c4709d2d32982068322662643e02f231
Currently
The regression is caused by the change:
vitess
Adds the capability for additional expressions that need to be resolved to
InjectedExpr
.Related PRs:
SELECT ... INTO OUTFILE ...
optionsWe had parser support for
SELECT ... INTO OUTFILE
, but were lacking parser support for the variety ofOUTFILE
options.This PR adds support for all the options and certain combinations of them.
However, we are missing support for duplicate options and certain orderings of these options; tests for these are added as error tests with a TODO.
MySQL Docs:
https://dev.mysql.com/doc/refman/8.0/en/select-into.html
MariaDB Docs (this has the actual grammar):
https://mariadb.com/kb/en/select-into-outfile/
This primarily adds a new AST node that DoltgreSQL takes advantage of. All currently-existing nodes are specifically designed for MySQL transformations. In many cases, Doltgres will have different transformations that need to take place, and this provides a way for Doltgres to implement those transformations without having to modify other packages whenever a new transformation is added or edited.
Related PRs:
Handler.ComResetConnection
to return an errorRelated to Implement COM_RESET_CONNECTION dolthub/dolt#3921
Closed Issues