-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hdf5: update to use parallel version of hdf5 #167668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some pretty big changes here that the description does not explain the reasons for. Please only change the serial vs parallel part in this review
03bc1a0
to
6efd0c4
Compare
Okay! I am starting to see the issues here. Hdf5 cannot be compiled with both libcpp-hdf5 (cpp bindings) and parallel option. Probably that is why hdf5-mpi exists. Maybe it is best to introduce petsc-mpi and petsc-complex-mpi for hdf5-mpi version? I am new to brew and unsure how to resolve this issue. Some help would be appreciated. @chenrui333 @fxcoudert |
26930f6
to
3f69666
Compare
hdf5 parallel is required for certain applications and should not conflict with serial applications as they are part of the same source code.
Maybe this could be hosted in a tap: https://docs.brew.sh/Taps, https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap |
Going to close this PR as current change is not the right approach. It doesn't package the standard
One thing you can explore is whether Another alternative is to wait for new conflict handling (Homebrew/brew#16398), which would automatically unlink one of the formulae rather than hard blocking on conflicts. Behavior would be similar to manual approach to conflicts (i.e. |
hdf5 parallel is required for certain applications and should not conflict with serial applications as they are part of the same source code. Having both creates linking conflicts.
Please revert PR #167477 and remove the formula hdf5-mpi as it becomes a duplicate of this.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?