Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openshift-cli 4.16.8 #182530

Merged
merged 2 commits into from
Aug 27, 2024
Merged

openshift-cli 4.16.8 #182530

merged 2 commits into from
Aug 27, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump

Created with brew bump-formula-pr.

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Aug 26, 2024
@p-linnane
Copy link
Member

We consistently have this issue with this formula. Starting to wonder if we should just deprecate it if upstream isn't going to fix the issue. Thoughts @Homebrew/core?

@Bo98
Copy link
Member

Bo98 commented Aug 27, 2024

What's the issue? We don't use tags here anymore.

@p-linnane
Copy link
Member

The version increment without a hash update was what I'm referring to.

stefanb
stefanb requested changes Aug 27, 2024
View reviewed changes
Copy link
Member

@stefanb stefanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sha256 wasn't changed

@MikeMcQuaid
Copy link
Member

This formula is 565th on https://formulae.brew.sh/analytics/install/365d/. If we want to bump it less often or something that seems fine but I don't think we should deprecate it just for this.

@stefanb
Copy link
Member

stefanb commented Aug 27, 2024 •
edited
Loading

In the mean time 4.16.9 was released: https://mirror.openshift.com/pub/openshift-v4/clients/ocp/4.16.9/
but is not yet marked as latest: https://mirror.openshift.com/pub/openshift-v4/clients/ocp/latest/

@Bo98
Copy link
Member

Bo98 commented Aug 27, 2024

OCP is a large platform of which the CLI is only one part of. They employ synchronised versioning so it is possible there was simply no CLI changes this time round.

@p-linnane p-linnane force-pushed the bump-openshift-cli-4.16.8 branch from e9eceaf to 5c8a405 Compare August 27, 2024 14:50
@p-linnane
Copy link
Member

OCP is a large platform of which the CLI is only one part of. They employ synchronised versioning so it is possible there was simply no CLI changes this time round.

Thanks @Bo98. That makes more sense. I've pushed a comment calling this out so there's no confusion in the future.

@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 27, 2024
@BrewTestBot BrewTestBot enabled auto-merge August 27, 2024 17:03
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 27, 2024
Merged via the queue into master with commit 42e1941 Aug 27, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-openshift-cli-4.16.8 branch August 27, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanb stefanb stefanb approved these changes

@carlocab carlocab carlocab approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BrewTestBot @p-linnane @Bo98 @MikeMcQuaid @stefanb @carlocab