Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crossplane 1.17.1 (new formula) #192300

Merged
merged 2 commits into from
Oct 2, 2024
Merged

crossplane 1.17.1 (new formula) #192300

merged 2 commits into from
Oct 2, 2024

Conversation

Moulick
Copy link
Contributor

@Moulick Moulick commented Sep 29, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

crossplane/crossplane#4899

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Sep 29, 2024
@Moulick Moulick changed the title Crossplane 1.17.0 Crossplane 1.17.0 (new formula) Sep 29, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 29, 2024
@Moulick Moulick marked this pull request as ready for review September 29, 2024 17:48
@Moulick Moulick marked this pull request as draft September 29, 2024 17:48
@Moulick Moulick changed the title Crossplane 1.17.0 (new formula) Crossplane 1.17.1 (new formula) Sep 29, 2024
@Moulick Moulick mentioned this pull request Sep 29, 2024
Open
@Moulick Moulick marked this pull request as ready for review September 29, 2024 18:00
Moulick
Moulick commented Sep 29, 2024
View reviewed changes
Formula/c/crossplane.rb Outdated Show resolved Hide resolved
chenrui333
chenrui333 reviewed Sep 29, 2024
View reviewed changes
Formula/c/crossplane.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 29, 2024
Moulick
Moulick commented Sep 29, 2024
View reviewed changes
Formula/c/crossplane.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 29, 2024
@Moulick Moulick force-pushed the crossplane-cli branch 2 times, most recently from b1d397b to 2df5389 Compare September 29, 2024 20:02
chenrui333
chenrui333 reviewed Sep 30, 2024
View reviewed changes
Formula/c/crossplane.rb Outdated Show resolved Hide resolved
@chenrui333 chenrui333 changed the title Crossplane 1.17.1 (new formula) crossplane 1.17.1 (new formula) Sep 30, 2024
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 30, 2024
chenrui333
chenrui333 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to squash the commits

@Moulick
crossplane 1.17.1 (new formula)
ac09bc9 
Signed-off-by: Moulick Aggarwal <[email protected]>
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 30, 2024
@Moulick
Copy link
Contributor Author

Moulick commented Sep 30, 2024

need to squash the commits

done!

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Oct 1, 2024
@Moulick
Copy link
Contributor Author

Moulick commented Oct 1, 2024

@chenrui333 is the open thread the reason for waiting to merge?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

:shipit: @nandahkrishna has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 2, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 2, 2024
Merged via the queue into Homebrew:master with commit edad4c8 Oct 2, 2024
15 checks passed
@Moulick Moulick deleted the crossplane-cli branch October 2, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phisco phisco phisco left review comments

@SMillerDev SMillerDev SMillerDev left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

@nandahkrishna nandahkrishna nandahkrishna approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Moulick @SMillerDev @chenrui333 @phisco @nandahkrishna @BrewTestBot