-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openexr 3.3.0 #192399
Merged
Merged
openexr 3.3.0 #192399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bump-formula-pr
PR was created using `brew bump-formula-pr`
label
Sep 30, 2024
chenrui333
approved these changes
Sep 30, 2024
chenrui333
force-pushed
the
bump-openexr-3.3.0
branch
from
September 30, 2024 20:47
faf30dc
to
c3c4daf
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
carlocab
added
CI-no-fail-fast
Continue CI tests despite failing GitHub Actions matrix builds.
and removed
stale
No recent activity
labels
Oct 3, 2024
carlocab
force-pushed
the
bump-openexr-3.3.0
branch
2 times, most recently
from
October 3, 2024 00:34
fc8c51c
to
d533132
Compare
|
carlocab
added a commit
to carlocab/CTL
that referenced
this pull request
Oct 3, 2024
C++17 now has `std::clamp`[^1], so the calls to `clamp` in this file cause the compiler to error with[^2] /tmp/ctl-20240930-89937-yvomao/CTL-ctl-1.5.3/OpenEXR_CTL/exrdpx/exrToDpx.cpp:172:19: error: call to 'clamp' is ambiguous 172 | (unsigned int) (clamp (float (pixel.r), 0.0f, 1023.0f) + 0.5f); | ^~~~~ /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/c++/v1/__algorithm/clamp.h:35:1: note: candidate function [with _Tp = float] 35 | clamp(_LIBCPP_LIFETIMEBOUND const _Tp& __v, | ^ /opt/homebrew/include/Imath/ImathFun.h:77:1: note: candidate function [with T = float] 77 | clamp (T a, T l, T h) IMATH_NOEXCEPT | ^ /tmp/ctl-20240930-89937-yvomao/CTL-ctl-1.5.3/OpenEXR_CTL/exrdpx/exrToDpx.cpp:175:19: error: call to 'clamp' is ambiguous 175 | (unsigned int) (clamp (float (pixel.g), 0.0f, 1023.0f) + 0.5f); | ^~~~~ /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/c++/v1/__algorithm/clamp.h:35:1: note: candidate function [with _Tp = float] 35 | clamp(_LIBCPP_LIFETIMEBOUND const _Tp& __v, | ^ /opt/homebrew/include/Imath/ImathFun.h:77:1: note: candidate function [with T = float] 77 | clamp (T a, T l, T h) IMATH_NOEXCEPT | ^ /tmp/ctl-20240930-89937-yvomao/CTL-ctl-1.5.3/OpenEXR_CTL/exrdpx/exrToDpx.cpp:178:19: error: call to 'clamp' is ambiguous 178 | (unsigned int) (clamp (float (pixel.b), 0.0f, 1023.0f) + 0.5f); | ^~~~~ /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/c++/v1/__algorithm/clamp.h:35:1: note: candidate function [with _Tp = float] 35 | clamp(_LIBCPP_LIFETIMEBOUND const _Tp& __v, | ^ /opt/homebrew/include/Imath/ImathFun.h:77:1: note: candidate function [with T = float] 77 | clamp (T a, T l, T h) IMATH_NOEXCEPT | ^ 3 errors generated. make[2]: *** [OpenEXR_CTL/exrdpx/CMakeFiles/exrdpx.dir/exrToDpx.cpp.o] Error 1 Both this code and `Imath::clamp` long predate `std::clamp`, so it seems to me that `Imath::clamp` is what's intended here. This fixes a build failure at Homebrew while rebuilding CTL for OpenEXR 3.3.0.[^3] [^1]: https://en.cppreference.com/w/cpp/algorithm/clamp [^2]: Logs available at https://github.com/Homebrew/homebrew-core/actions/runs/11113893071/job/30879442929?pr=192399#step:3:375 [^3]: See Homebrew/homebrew-core#192399
michaeldsmith
pushed a commit
to ampas/CTL
that referenced
this pull request
Oct 3, 2024
C++17 now has `std::clamp`[^1], so the calls to `clamp` in this file cause the compiler to error with[^2] /tmp/ctl-20240930-89937-yvomao/CTL-ctl-1.5.3/OpenEXR_CTL/exrdpx/exrToDpx.cpp:172:19: error: call to 'clamp' is ambiguous 172 | (unsigned int) (clamp (float (pixel.r), 0.0f, 1023.0f) + 0.5f); | ^~~~~ /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/c++/v1/__algorithm/clamp.h:35:1: note: candidate function [with _Tp = float] 35 | clamp(_LIBCPP_LIFETIMEBOUND const _Tp& __v, | ^ /opt/homebrew/include/Imath/ImathFun.h:77:1: note: candidate function [with T = float] 77 | clamp (T a, T l, T h) IMATH_NOEXCEPT | ^ /tmp/ctl-20240930-89937-yvomao/CTL-ctl-1.5.3/OpenEXR_CTL/exrdpx/exrToDpx.cpp:175:19: error: call to 'clamp' is ambiguous 175 | (unsigned int) (clamp (float (pixel.g), 0.0f, 1023.0f) + 0.5f); | ^~~~~ /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/c++/v1/__algorithm/clamp.h:35:1: note: candidate function [with _Tp = float] 35 | clamp(_LIBCPP_LIFETIMEBOUND const _Tp& __v, | ^ /opt/homebrew/include/Imath/ImathFun.h:77:1: note: candidate function [with T = float] 77 | clamp (T a, T l, T h) IMATH_NOEXCEPT | ^ /tmp/ctl-20240930-89937-yvomao/CTL-ctl-1.5.3/OpenEXR_CTL/exrdpx/exrToDpx.cpp:178:19: error: call to 'clamp' is ambiguous 178 | (unsigned int) (clamp (float (pixel.b), 0.0f, 1023.0f) + 0.5f); | ^~~~~ /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/c++/v1/__algorithm/clamp.h:35:1: note: candidate function [with _Tp = float] 35 | clamp(_LIBCPP_LIFETIMEBOUND const _Tp& __v, | ^ /opt/homebrew/include/Imath/ImathFun.h:77:1: note: candidate function [with T = float] 77 | clamp (T a, T l, T h) IMATH_NOEXCEPT | ^ 3 errors generated. make[2]: *** [OpenEXR_CTL/exrdpx/CMakeFiles/exrdpx.dir/exrToDpx.cpp.o] Error 1 Both this code and `Imath::clamp` long predate `std::clamp`, so it seems to me that `Imath::clamp` is what's intended here. This fixes a build failure at Homebrew while rebuilding CTL for OpenEXR 3.3.0.[^3] [^1]: https://en.cppreference.com/w/cpp/algorithm/clamp [^2]: Logs available at https://github.com/Homebrew/homebrew-core/actions/runs/11113893071/job/30879442929?pr=192399#step:3:375 [^3]: See Homebrew/homebrew-core#192399
carlocab
force-pushed
the
bump-openexr-3.3.0
branch
from
October 3, 2024 05:34
d533132
to
b7279af
Compare
carlocab
added
the
CI-no-fail-fast-deps
Continue dependent tests despite failing GitHub Actions matrix tests.
label
Oct 3, 2024
Also, apply a patch to fix a build failure with newer OpenEXR. Co-authored-by: Carlo Cabrera <[email protected]> Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
carlocab
force-pushed
the
bump-openexr-3.3.0
branch
from
October 3, 2024 13:50
b7279af
to
ce87ad8
Compare
carlocab
approved these changes
Oct 3, 2024
github-actions
bot
added
the
CI-published-bottle-commits
The commits for the built bottles have been pushed to the PR branch.
label
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump-formula-pr
PR was created using `brew bump-formula-pr`
CI-linux-self-hosted
Build on Linux self-hosted runner
CI-no-fail-fast
Continue CI tests despite failing GitHub Actions matrix builds.
CI-no-fail-fast-deps
Continue dependent tests despite failing GitHub Actions matrix tests.
CI-published-bottle-commits
The commits for the built bottles have been pushed to the PR branch.
long build
Set a long timeout for formula testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
The C++ API now uses the OpenEXRCore library underneath.
New API for accessing compression types
In anticipation of future support for new compression types, there is now a convenience API for mapping between compression type names and the associated enum:
New bin tools:
exrmetrics - Read an OpenEXR image from infile, write an identical copy to outfile reporting time taken to read/write and file sizes. Useful for benchmarking performance in space and time.
exrmanifest - Read exr files and print the contents of the embedded manifest. The manifest provides a mapping between integer object identifiers and human-readible strings. See OpenEXR Deep IDs Specification for more details.
New python bindings.
This version introduces a new python API, the File object, which provides full support for reading and writing all types of .exr image files, including scanline, tiled, deep, mult-part, multi-view, and multi-resolution images with pixel types of unsigned 32-bit integers and 16- and 32-bit floats. It provides access to pixel data through numpy arrays, as either one array per channel or with R, G, B, and A interleaved into a single array RGBA array.
Previous releases of the openexr python module supported only scanline files. The previous API remains in place for now for backwards compatibility.
See src/wrappers/python/README.md for a synopsis.