-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bats-core 0.4.0 (new formula) #20073
Conversation
First of all, thanks for the PR! Based on the README, this release isn't considered stable yet:
Per our formulae guidelines, we can't accept new formulae without a stable version. I'll leave some review notes above for when this does get to a stable release. Sorry, and thanks again! |
url "https://github.com/bats-core/bats-core/archive/v0.4.0.tar.gz" | ||
sha256 "e3b65b50a26e3f0c33b5d0a57d74101acf096e39473294d4840635ca6206fec7" | ||
|
||
bottle :unneeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can drop this line -- we prefer to build bottles of shell-only packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Or maybe not...I see that we allowed for :unneeded
in the original bats
.)
system "./install.sh", prefix | ||
end | ||
|
||
def caveats; <<~EOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't usually like long caveats
blobs like this. If bats
and bats-core
can't play nice when installed at the same time, a conflicts_with
statement would be a little cleaner and catch potential mistakes earlier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an example:
conflicts_with "bats", :because => "both install a `bats` binary"
@woodruffw Fantastic I really appreciate those tips, thanks! (FWIW There's no new code, this formula simply changes the download origin of the package to the new repo), but I'll definitely update the formula and incorporate this feedback for our stable release! :) |
Awesome! FWIW, I'm 👍 on removing |
@woodruffw Thank you! That'll be a huge help :D |
Superseded by #28977 |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?bats-core is the revival and the happy, growing continuation of the original bats. As there are a good number of
bats
users and there's been momentum on users migrating tobats-core
, we thought it would be prudent to update package manager formulae and release long-anticipated updates as soon as possible.Side note: There are currently no naming conflicts with this formula and the pre-existing
bats
formula. But, if the maintainers could give me some advice on how one would "replace" an existing formula that's been seemingly abandoned ~3 years or so, I would be thankful. I'm not sure how common this situation is, and if there are already guidelines on it. Thanks!