Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asdf 0.16.0 #205761

Merged
merged 2 commits into from
Feb 5, 2025
Merged

asdf 0.16.0 #205761

merged 2 commits into from
Feb 5, 2025

Conversation

Stratus3D
Copy link
Contributor

@Stratus3D Stratus3D commented Jan 28, 2025 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

asdf v0.15.0 is the mot recent tag of asdf and the version currently available via Homebrew. I've been preparing to release asdf asdf v0.16.0, which is a complete rewrite in Go. Because of the change of language, the build and install process changes significantly. Overall the formula is more straightforward now and more in line with the numerous other Go tools distributed via Homebrew.

Currently brew audit --strict asdf is failing because a version must be specified, but the new version of asdf that goes with these changes has not been tagged yet (it will be shortly).

Related PRs:

@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Jan 28, 2025
Stratus3D
Stratus3D commented Jan 28, 2025
View reviewed changes
Formula/a/asdf.rb Outdated Show resolved Hide resolved
Stratus3D
Stratus3D commented Jan 28, 2025
View reviewed changes
Formula/a/asdf.rb Outdated Show resolved Hide resolved
@SMillerDev SMillerDev added the prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies label Jan 28, 2025
@Stratus3D
Copy link
Contributor Author

@SMillerDev I've updated the PR based on your comments, it's much simpler now. asdf v0.16.0 hasn't been released yet so I'm keeping this marked as a draft.

@Stratus3D Stratus3D changed the title asdf: prepare for v0.16.0 release asdf: update for v0.16.0 release Jan 30, 2025
@Stratus3D Stratus3D marked this pull request as ready for review January 30, 2025 01:48
@Stratus3D Stratus3D force-pushed the master branch 2 times, most recently from eccda73 to 21b0534 Compare January 30, 2025 01:51
@Stratus3D
Copy link
Contributor Author

Hi @SMillerDev , I updated this PR with a new tag and revision for the URL as asdf v0.16.0 was tagged this evening. It now passes brew audit --strict <formula>.

@Stratus3D Stratus3D changed the title asdf: update for v0.16.0 release asdf: v0.16.0 update Jan 30, 2025
@chenrui333 chenrui333 changed the title asdf: v0.16.0 update asdf 0.16.0 Jan 30, 2025
@chenrui333 chenrui333 mentioned this pull request Jan 30, 2025
Closed
chenrui333
chenrui333 reviewed Jan 30, 2025
View reviewed changes
Formula/a/asdf.rb Outdated Show resolved Hide resolved
@chenrui333
Copy link
Member

chenrui333 commented Jan 30, 2025 •
edited
Loading

@Stratus3D also need to amend the commit msg as asdf 0.16.0.

@Stratus3D
Copy link
Contributor Author

@Stratus3D also need to amend the commit msg as asdf 0.16.0.

PR updated.

@samford samford removed the prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies label Jan 30, 2025
p-linnane
p-linnane reviewed Jan 30, 2025
View reviewed changes
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Stratus3D! One minor nit and then this should be good to go.

Formula/a/asdf.rb Outdated Show resolved Hide resolved
@Stratus3D
Copy link
Contributor Author

@p-linnane PR has been updated.

@p-linnane
Copy link
Member

@Stratus3D Please see my outstanding comment. We still need -w in the ldflags.

@Stratus3D
Copy link
Contributor Author

PR updated @p-linnane

SMillerDev
SMillerDev approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Stratus3D ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@SMillerDev SMillerDev added this pull request to the merge queue Jan 31, 2025
@stefanb
Copy link
Member

stefanb commented Feb 1, 2025

The all bottle split workaround is ready in

@Stratus3D
Copy link
Contributor Author

Thanks @stefanb !

github-merge-queue bot pushed a commit that referenced this pull request Feb 2, 2025
@BrewTestBot
Merge pull request #206271 from Homebrew/asdf-all-bottle-block-split
0e72932 
asdf: bottle block split for #205761
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 2, 2025

:shipit: @stefanb has requested bottles to be published to this PR.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 2, 2025

⚠️ @stefanb bottle publish failed.

@stefanb
Copy link
Member

stefanb commented Feb 2, 2025 •
edited
Loading

@Stratus3D please rebase this PR branch onto the latest master.

@stefanb
Copy link
Member

stefanb commented Feb 2, 2025 •
edited
Loading

Ah, the workaround #206271 was automagically mostly reverted in bfbd802 so there is only one all bottle again...

@eugenejeonme eugenejeonme mentioned this pull request Feb 3, 2025
Closed
@Stratus3D
Copy link
Contributor Author

@stefanb I rebased onto current master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

🤖 An automated task has requested bottles to be published to this PR.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

⚠️ Bottle publish failed.

@missingcharacter missingcharacter mentioned this pull request Feb 4, 2025
Merged
@daeho-ro daeho-ro mentioned this pull request Feb 5, 2025
Merged
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Feb 5, 2025
@Stratus3D @daeho-ro
asdf 0.16.0
20d53c7 
asdf v0.16.0 has been released. It is a complete rewrite in Go. Because of the
change of language, the build and install process changes significantly. Overall
the formula is more straightforward now and more in line with the numerous other
Go tools distributed via Homebrew.

asdf: bottle block split
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Feb 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Feb 5, 2025
@BrewTestBot BrewTestBot enabled auto-merge February 5, 2025 15:18
@p-linnane
Copy link
Member

@Stratus3D Sorry for the hold up here. We had a bug on our end that was preventing this from being published correctly. This should merge shortly and we will rebase the other PR bumping the version. Thanks for your contribution and patience!

@Stratus3D
Copy link
Contributor Author

Thanks for the update!

@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 5, 2025
Merged via the queue into Homebrew:master with commit ebc9d7b Feb 5, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cho-m cho-m cho-m left review comments

@samford samford samford left review comments

@chenrui333 chenrui333 chenrui333 left review comments

@p-linnane p-linnane p-linnane approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@carlocab carlocab carlocab approved these changes

@SMillerDev SMillerDev SMillerDev approved these changes

@stefanb stefanb stefanb approved these changes

Assignees
No one assigned
Labels
brew Issue may be Homebrew/brew related CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Stratus3D @chenrui333 @p-linnane @cho-m @stefanb @SMillerDev @samford @carlocab @BrewTestBot