Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite 3.32.2 #55804

Closed
wants to merge 1 commit into from
Closed

sqlite 3.32.2 #55804

wants to merge 1 commit into from

Conversation

miccal
Copy link
Member

@miccal miccal commented Jun 4, 2020

Created with brew bump-formula-pr.

@miccal
Copy link
Member Author

miccal commented Jun 5, 2020

Error: 5 failed steps!
brew test --verbose agda
brew test --verbose alure
brew test --verbose bnfc
brew test --verbose bowtie2
brew test --verbose graphite2

@samford
Copy link
Member

samford commented Jun 5, 2020

The agda and bnfc failures are due to cabal_sandbox being deprecated and will be handled as part of #55253 (there's already #55854 for bnfc). alure is simply one of the sound-related formulae with a test that regularly fails on CI (as in #55191). Failures for bowtie2 and graphite2 are as follows:

==> brew test --verbose bowtie2
==> FAILED
Testing bowtie2
/usr/bin/sandbox-exec -f /private/tmp/homebrew20200605-30702-1dsyxk1.sb ruby -W0 -I $LOAD_PATH -- /usr/local/Homebrew/Library/Homebrew/test.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/bowtie2.rb --verbose
==> /usr/local/Cellar/bowtie2/2.4.1/bin/bowtie2-build /usr/local/Cellar/bowtie2/2.4.1/share/bowtie2/example/reference/lambda_virus.fa lambda_virus
env: python3: No such file or directory
Error: bowtie2: failed
An exception occurred within a child process:
  BuildError: Failed executing: /usr/local/Cellar/bowtie2/2.4.1/bin/bowtie2-build /usr/local/Cellar/bowtie2/2.4.1/share/bowtie2/example/reference/lambda_virus.fa lambda_virus

This test failure is due to bowtie2-build being a Python script but Python isn't loaded in the bowtie2 formula. There are a couple different ways to deal with this situation and I'll be discussing it with maintainers to determine how to address the issue.

==> brew test --verbose graphite2
==> FAILED
Testing graphite2
/usr/bin/sandbox-exec -f /private/tmp/homebrew20200605-3286-5gciq0.sb ruby -W0 -I $LOAD_PATH -- /usr/local/Homebrew/Library/Homebrew/test.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/graphite2.rb --verbose
==> Downloading https://scripts.sil.org/pub/woff/fonts/Simple-Graphite-Font.ttf
/usr/bin/curl --disable --globoff --show-error --user-agent Homebrew/2.3.0-37-g49324ad\ \(Macintosh\;\ Intel\ Mac\ OS\ X\ 10.13.6\)\ curl/7.54.0 --fail --silent --retry 3 --location --remote-time --continue-at 0 --output /Users/brew/Library/Caches/Homebrew/downloads/f3defb70b069df7b82cf2d5e02caf9bf171a4c8d92a077d38ac3a16637c09ff0--Simple-Graphite-Font.ttf.incomplete https://scripts.sil.org/pub/woff/fonts/Simple-Graphite-Font.ttf
curl: (7) Failed to connect to scripts.sil.org port 443: Connection refused
Error: graphite2: failed
An exception occurred within a child process:
  DownloadError: Failed to download resource "graphite2--testfont"
Download failed: https://scripts.sil.org/pub/woff/fonts/Simple-Graphite-Font.ttf

The test file for graphite2 wasn't accessible around the time of the test but it's back now.


Unless there's something actionable about the bowtie2 failure (e.g., if someone has seen this failure before and/or it happens regularly on CI), I think we're fine merging this.

If you could also create a PR to bump dbhash, that would be helpful. We usually do sqlite, dbhash, sqldiff, and sqlite-analyzer all in one PR (like #55191) but you've already done the others separately.

@miccal
Copy link
Member Author

miccal commented Jun 5, 2020

@samford dbhash is here.

@BrewTestBot
Copy link
Member

:shipit: @samford has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ @samford bottle publish failure.

@samford
Copy link
Member

samford commented Jun 5, 2020

dbhash is here.

Ha, I searched for dbhash PRs but somehow overlooked it. Tired brain 😪

bottle publish failure.

This again. I'll have to bother another maintainer to merge this, since the last sqlite PR ran into a bottle publish issue as well and it's a bit tricky to deal with.

Anyway, thanks @miccal!

@BrewTestBot
Copy link
Member

:shipit: @samford has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ @samford bottle publish failure.

@miccal miccal mentioned this pull request Jun 16, 2020
@SMillerDev
Copy link
Member

The bottles seem to be broken so I'm running this again.

@samford
Copy link
Member

samford commented Jun 16, 2020

The bottles seem to be broken so I'm running this again.

This is the same bottle issue that we encountered in #55191 and @Bo98 had to work some magic and manually merge that PR. Unless something has changed in the interim time, I don't imagine we'll be able to merge this after another run either (see the two failures above). It requires some manual labor to merge sqlite at the moment and I don't know what Bo's process is (to be able to replicate it).

@miccal
Copy link
Member Author

miccal commented Jun 18, 2020

Closing as 3.32.3 is now available.

Thanks you @samford and @SMillerDev for your help.

@miccal miccal closed this Jun 18, 2020
@miccal miccal deleted the sqlite-3.32.2 branch June 18, 2020 21:19
@miccal
Copy link
Member Author

miccal commented Jun 18, 2020

#56512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants