Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhall-lsp-server: fix cabal sandbox warnings #55847

Closed

Conversation

pthariensflame
Copy link
Contributor

@pthariensflame pthariensflame commented Jun 5, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Resolves dhall-lsp-server's part of #55253.

@chenrui333 chenrui333 added the cabal v1 deprecation Deprecate cabal sandbox label Jun 6, 2020
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pthariensflame ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@pthariensflame pthariensflame deleted the fix/dhall-lsp-server branch June 9, 2020 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cabal v1 deprecation Deprecate cabal sandbox
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants