Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

texmath 0.12.0.3 #67169

Closed
wants to merge 1 commit into from
Closed

texmath 0.12.0.3 #67169

wants to merge 1 commit into from

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Dec 18, 2020

  • bump version
  • update license
  • fix build

Cf. #65759


  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

- bump version
- update license
- fix build
@BrewTestBot BrewTestBot added the haskell Haskell use is a significant feature of the PR or issue label Dec 18, 2020
@carlocab carlocab mentioned this pull request Dec 18, 2020
@fxcoudert
Copy link
Member

What does -fexecutable do?

@carlocab
Copy link
Member Author

carlocab commented Dec 18, 2020

-f is the short form of --flags= (I actually meant to put it back in the long-form before pushing...)

My understanding is that it turns on some targets in whatever cabal's equivalent of a Makefile is. So -fexecutable sets the executable target to true. (Why it would be false by default is beyond me.) At least, I think that's what it does. I don't really understand cabal, and I've tried reading their docs.

Found it here: https://johnmacfarlane.net/texmath.html (Click "Installing")

license "GPL-2.0"
url "https://hackage.haskell.org/package/texmath-0.12.0.3/texmath-0.12.0.3.tar.gz"
sha256 "318771c696dfa4fc57edf984f3aa35f0cb1792119cf2e27601b6267d9e1d4918"
license "GPL-2.0-only"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license "GPL-2.0-only"
license "GPL-2.0-or-later"
{-
Copyright (C) 2009-2012 John MacFarlane <[email protected]>

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
-}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you grab the license info from the haskell registry, which is wrong with the license declarations in the files :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did get it from the Haskell registry! Whoops. I should've double-checked. Thanks for checking 👍

@chenrui333
Copy link
Member

we can totally update the license in the following PR though.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@carlocab carlocab deleted the texmath-0.12.0.3 branch December 19, 2020 01:03
@carlocab carlocab mentioned this pull request Dec 19, 2020
5 tasks
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 18, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
haskell Haskell use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants