fix futhark build failed in ghc 8.10.3 #67363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrewTestBot
added
the
haskell
|
Thanks for this. Haven't had a chance to take a closer look at the CI failures so I wasn't able to figure out how to fix them yet. |
carlocab
reviewed
Dec 21, 2020
carlocab
reviewed
Dec 21, 2020
|
Picked up your commit with minor revisions, and included it here: #67284 Hopefully, it fixes some build failures... |
Co-authored-by: Carlo Cabrera <[email protected]>
carlocab
reviewed
Dec 22, 2020
| @@ -4,6 +4,7 @@ class Futhark < Formula | |||
| url "https://github.com/diku-dk/futhark/archive/v0.18.4.tar.gz" | |||
| sha256 "262dd8024c58ebb05964010227bc76907c873f261ab3348ffeab5fa5b1def022" | |||
| license "ISC" | |||
| revision 1 | |||
There was a problem hiding this comment.
Suggested change
| revision 1 |
The revision is not needed.
|
You can actually close this now. If/when the ghc PR is merged this commit will be recorded as authored by you: f8c0738 |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?fixes for #67284, cause by
process-extras's transitive dependency ofListLike(ddssff/listlike#8)