Remove agda from dependency conflict allowlist #68154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The versioned dependency conflict was resolved in Homebrew#67014.
carlocab
added
the
CI-syntax-only
BrewTestBot
added
the
automerge-skip
chenrui333
approved these changes
Jan 2, 2021
Rylan12
approved these changes
Jan 2, 2021
There was a problem hiding this comment.
Awesome, thanks!
FYI this can be done in the same PR as the change itself. I'm planning on adding some functionality that will cause audit to fail if the formula is in a list like this but should be removed. This will (hopefully) help us keep these lists clean. Otherwise, it's really easy for stuff to be forgotten. Once that's done, you'll have to make the change in the same PR. Who knows when (if) I'll get to that...
|
That’d be pretty cool. It would make sure we don’t forget to take care of this stuff. As for not having done this with the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The versioned dependency conflict was resolved in #67014.