Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and functionality #1

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

hellblazer315
Copy link

@hellblazer315 hellblazer315 commented Mar 14, 2024

Merging to Hossy as it seems to have built upon origin in healthy ways and origin hasn't had a new commit/PR accept in 2 years.

  • Update of all dependencies to current latest.

  • Updated Docker readme to function from no matter your current directory.

  • Added a docker.env file to specify container userspace and timezone.

  • Added & documented functionality around date and timezone logging.

  • Added a line to the log file when each library initates for easier tracking and debugging.

  • Updated log/debug ouput to put raw values of all scored attributes in line with their score.

  • Added final score to beginning of the readout for the decisions log.

  • Add some of the feature addition created in Tackyou/plex_dupefinder:

    • Cleaner result printing
      • ✨ successful deletion
      • ⚠️ failed deletion
      • ✅ keep file
      • ☑️ ignore/skip file
      • ❌ delete file
      • 🆔 file id
    • Ignore system specific files
    • New scoring options: Toggle for audiochannels and videobitrate, multiplier for videobitrate and videowidth
      • Extended this further with video bitrate and height multipliers).
    • Better regex for deletefiles.sh
      • Maintained origin regex for easy revert.
    • Better evidence for the source value of a score.

Note from Tackyou (attempted to account for this and already changed the technique up, it does still require 3 parts in the path though.) :

Something that might be an issue:
shortenedFilePath = '/' + '/'.join(part_info['file'][0].split('/')[-3:]) will cut out the last 3 parts of the path.
For example /path/to/the/mount/Movies/stuff.mkv would show as /mount/Movies/stuff.mkv
This is supposed to make the output easier to read by removing uninteresting stuff from the path, but if the path is less than 3 folders deep it will most likely throw an error.
It probably also doesn't work on Windows Plex servers due to the backward slashes.
Maybe remove this part before merging. (easiest way is to change it to shortenedFilePath = part_info['file'][0])

- Cleaner result printing
- Ignore system specific files
- Config toggle for audiochannels and videobitrate
- Better regex for deletefiles.sh
…config file.

Updated log/debug ouput to put raw values of all scored attributes in line with their score.
Changed the way file path is being shortened so that it should work both with Windows and for manual/debugging workflows instead of only in the "decisions.log" file.
- Updated Docker readme to function from no matter your current directory.
- Added a docker.env file to specify container userspace and timezone.
- Added & documented functionality around date and timezone logging.
-  Added a line to the log file when each library initates for easier tracking and debugging.
- Added final score to beginning of the readout for the decisions log.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant