Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A small set of bug fixes #1415

Merged
merged 11 commits into from
Jan 17, 2025
Merged

A small set of bug fixes #1415

merged 11 commits into from
Jan 17, 2025

Conversation

AlecAivazis
Copy link
Collaborator

@AlecAivazis AlecAivazis commented Jan 17, 2025

This PR fixes a few minor bugs:

  • In react, if a url parameter was URI encoded, the encoded value was being passed as a variable. It's now decoded correctly
  • If 2 operations that references the same field on a parent, the operation was happening twice. For example, if a field was tagged with 2 different @lists and both were included to ensure the mutation had the necessary fields for both, the value was inserted twice.
  • If a @list tagged field contained sublists, we wouldn't include pageInfo in the operation fragments which was causing an issue when reading the values back.
  • If an exported load function was just the result of a function call (or a straight reference) it wasn't wrapped correctly

To help everyone out, please make sure your PR does the following:

  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

Copy link

changeset-bot bot commented Jan 17, 2025

🦋 Changeset detected

Latest commit: a65d606

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
houdini-svelte Patch
houdini Patch
houdini-adapter-static Minor
houdini-react Patch
houdini-adapter-auto Minor
houdini-adapter-cloudflare Minor
houdini-adapter-node Minor
houdini-plugin-svelte-global-stores Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for houdini-docs-next canceled.

Name Link
🔨 Latest commit a65d606
🔍 Latest deploy log https://app.netlify.com/sites/houdini-docs-next/deploys/678adf0b09760800087f76de

@AlecAivazis AlecAivazis changed the title Route params with space A small set of bug fixes Jan 17, 2025
Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for houdinigraphql canceled.

Name Link
🔨 Latest commit a65d606
🔍 Latest deploy log https://app.netlify.com/sites/houdinigraphql/deploys/678adf0b5c3dee0008ba367a

@AlecAivazis AlecAivazis merged commit d0b1168 into main Jan 17, 2025
15 checks passed
@AlecAivazis AlecAivazis deleted the route-params-with-space branch January 17, 2025 23:04
@github-actions github-actions bot mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant