Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix import path resolution issue #1423

Merged
merged 2 commits into from
Jan 23, 2025
Merged

fix import path resolution issue #1423

merged 2 commits into from
Jan 23, 2025

Conversation

AlecAivazis
Copy link
Collaborator

Fixes #1401

This PR fixes an issue with the svelte plugin that was breaking imports in vite 6. I'm still unsure if this is the right approach so i'm waiting to hear back from someone who knows better but I wanted to open this up for others to test.

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

Copy link

changeset-bot bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: 9a68a8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
houdini-svelte Patch
houdini-plugin-svelte-global-stores Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for houdini-docs-next canceled.

Name Link
🔨 Latest commit 9a68a8a
🔍 Latest deploy log https://app.netlify.com/sites/houdini-docs-next/deploys/6790978585bfbc00087af19e

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for houdinigraphql canceled.

Name Link
🔨 Latest commit 9a68a8a
🔍 Latest deploy log https://app.netlify.com/sites/houdinigraphql/deploys/6790978588171b00083e6a56

@AlecAivazis AlecAivazis merged commit 158d70d into main Jan 23, 2025
15 checks passed
@AlecAivazis AlecAivazis deleted the vite-6-fix branch January 23, 2025 07:48
@github-actions github-actions bot mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Houdini Vite plugin doesn't support Vite 6
1 participant