Support SSL client certificate options per request #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extend cUrl parser to parse: * -E or --cert * --key * --pass * --cacert extend httpRequest to have https options. prefere https options of the request over the https options from the settings
extract and highlight https options from the per request settings comments
- resolve variables before processing the options - reference the variable usage inside the "comment" - provide error if the variable was not found
cplussharp
changed the title
command line options where only used, if the request had https options
system/env/dotenv variables have a space inside so now the regex interprets everything after the var name as value (before only the first "word without space" was used)
as the history http file is created in a temp dir: resolve relative certificate paths in place so the history has the absolute path
as HAR does not support https options, the CLI parameters are added manualy
|
This should now cover every places: httpParser, curlParser, syntax highlighting, variable support, history, curl command generation and output of the parameters in response view. The only thing not working is the CodeSnipped generator, because "httpsnipped" does not support client certificates :-( |
the httpsArgs with the certificate where overriden by the key args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extend cUrl parser to parse:
extend httpRequest to have https options.
prefere https options of the request
over the https options from the settings