Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README to reflect v1 #328

Merged
merged 3 commits into from
Jul 8, 2019
Merged

update README to reflect v1 #328

merged 3 commits into from
Jul 8, 2019

Conversation

calvinnhieu
Copy link
Collaborator

@calvinnhieu calvinnhieu self-assigned this Jun 25, 2019
@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #328 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   83.57%   83.57%           
=======================================
  Files          28       28           
  Lines        1638     1638           
=======================================
  Hits         1369     1369           
  Misses        269      269

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25b985...8c627d4. Read the comment docs.

5 similar comments
@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #328 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   83.57%   83.57%           
=======================================
  Files          28       28           
  Lines        1638     1638           
=======================================
  Hits         1369     1369           
  Misses        269      269

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25b985...8c627d4. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #328 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   83.57%   83.57%           
=======================================
  Files          28       28           
  Lines        1638     1638           
=======================================
  Hits         1369     1369           
  Misses        269      269

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25b985...8c627d4. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #328 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   83.57%   83.57%           
=======================================
  Files          28       28           
  Lines        1638     1638           
=======================================
  Hits         1369     1369           
  Misses        269      269

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25b985...8c627d4. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #328 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   83.57%   83.57%           
=======================================
  Files          28       28           
  Lines        1638     1638           
=======================================
  Hits         1369     1369           
  Misses        269      269

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25b985...8c627d4. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #328 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   83.57%   83.57%           
=======================================
  Files          28       28           
  Lines        1638     1638           
=======================================
  Hits         1369     1369           
  Misses        269      269

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25b985...8c627d4. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #328 into master will decrease coverage by 0.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
- Coverage   84.41%   83.83%   -0.59%     
==========================================
  Files          29       29              
  Lines        1720     2004     +284     
==========================================
+ Hits         1452     1680     +228     
- Misses        268      324      +56
Impacted Files Coverage Δ
matrix/common/constants.py 90% <0%> (-3.55%) ⬇️
matrix/docker/matrix_converter.py 35.05% <0%> (-2.8%) ⬇️
matrix/lambdas/daemons/v0/driver.py 87.73% <0%> (-1.8%) ⬇️
matrix/common/aws/batch_handler.py 100% <0%> (ø) ⬆️
matrix/lambdas/daemons/notification.py 100% <0%> (ø) ⬆️
matrix/lambdas/api/v1/core.py 99.3% <0%> (+0.2%) ⬆️
matrix/lambdas/api/v0/core.py 99% <0%> (+0.35%) ⬆️
matrix/common/etl/__init__.py 96.27% <0%> (+1.87%) ⬆️
matrix/common/etl/transformers/cell_expression.py 75.38% <0%> (+2.59%) ⬆️
matrix/common/etl/transformers/feature.py 92.3% <0%> (+3.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee4a9f4...0a615d5. Read the comment docs.

@brianraymor
Copy link

For #322 The difference in the v0 and v1 endpoints don't seem to be explained. - does the README clearly differentiate v0 (contract with the data browser - not intended for humans) and v1 (developer friendly)?

Copy link
Contributor

@mckinsel mckinsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple little things to add/look at, but generally looks good to merge.

@@ -1,79 +1,129 @@
# Expression Matrix Service

[![Production Health Check](https://status.data.humancellatlas.org/service/matrix-health-check-prod.svg)](https://matrix.data.humancellatlas.org/)
[![Master Deployment Status](https://status.data.humancellatlas.org/build/HumanCellAtlas/matrix-service/prod.svg)](https://allspark.dev.data.humancellatlas.org/HumanCellAtlas/matrix-service/pipelines)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the allspark build badges stop working? I remember looking into fixing this a while ago but couldn't figure it out.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm I think the badge we were using was hosted on @mweiden's service status dashboard which made them public. Not sure what happened, but those badges don't work anymore. GitLab badges still work, but you have to authenticate to see them which doesn't work in a README:

https://allspark-prod.data.humancellatlas.org/HumanCellAtlas/matrix-service/badges/prod/pipeline.svg

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@calvinnhieu
Copy link
Collaborator Author

@brianraymor addressed, in Versions section

@calvinnhieu calvinnhieu merged commit 1939dcd into master Jul 8, 2019
@calvinnhieu calvinnhieu deleted the v1-readme branch July 8, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants