-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update README to reflect v1 #328
Conversation
calvinnhieu
commented
Jun 25, 2019
- supporting documentation https://allspark.dev.data.humancellatlas.org/HumanCellAtlas/matrix-service/wikis/Technical-Architecture
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
=======================================
Coverage 83.57% 83.57%
=======================================
Files 28 28
Lines 1638 1638
=======================================
Hits 1369 1369
Misses 269 269 Continue to review full report at Codecov.
|
5 similar comments
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
=======================================
Coverage 83.57% 83.57%
=======================================
Files 28 28
Lines 1638 1638
=======================================
Hits 1369 1369
Misses 269 269 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
=======================================
Coverage 83.57% 83.57%
=======================================
Files 28 28
Lines 1638 1638
=======================================
Hits 1369 1369
Misses 269 269 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
=======================================
Coverage 83.57% 83.57%
=======================================
Files 28 28
Lines 1638 1638
=======================================
Hits 1369 1369
Misses 269 269 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
=======================================
Coverage 83.57% 83.57%
=======================================
Files 28 28
Lines 1638 1638
=======================================
Hits 1369 1369
Misses 269 269 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
=======================================
Coverage 83.57% 83.57%
=======================================
Files 28 28
Lines 1638 1638
=======================================
Hits 1369 1369
Misses 269 269 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
- Coverage 84.41% 83.83% -0.59%
==========================================
Files 29 29
Lines 1720 2004 +284
==========================================
+ Hits 1452 1680 +228
- Misses 268 324 +56
Continue to review full report at Codecov.
|
For #322 The difference in the v0 and v1 endpoints don't seem to be explained. - does the README clearly differentiate v0 (contract with the data browser - not intended for humans) and v1 (developer friendly)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple little things to add/look at, but generally looks good to merge.
@@ -1,79 +1,129 @@ | |||
# Expression Matrix Service | |||
|
|||
[![Production Health Check](https://status.data.humancellatlas.org/service/matrix-health-check-prod.svg)](https://matrix.data.humancellatlas.org/) | |||
[![Master Deployment Status](https://status.data.humancellatlas.org/build/HumanCellAtlas/matrix-service/prod.svg)](https://allspark.dev.data.humancellatlas.org/HumanCellAtlas/matrix-service/pipelines) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did the allspark build badges stop working? I remember looking into fixing this a while ago but couldn't figure it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm I think the badge we were using was hosted on @mweiden's service status dashboard which made them public. Not sure what happened, but those badges don't work anymore. GitLab badges still work, but you have to authenticate to see them which doesn't work in a README:
https://allspark-prod.data.humancellatlas.org/HumanCellAtlas/matrix-service/badges/prod/pipeline.svg
@brianraymor addressed, in Versions section |