Remove genes.tsv.gz from mtx format #424
Conversation
|
|
||
| <h3><code>barcodes.tsv.gz</code></h3> | ||
| <p>A list of cell barcodes corresponding to the columns found in matrix.mtx.gz. | ||
| Note that barcodes may not be unique.</p> |
There was a problem hiding this comment.
@mckinsel What do you recommend we use instead to ensure uniqueness across projects? Will storing something other than barcodes in this file cause confusion?
| @@ -459,7 +459,7 @@ class MetadataSchemaName(Enum): | |||
| MatrixFormat.MTX.value: """ | |||
There was a problem hiding this comment.
Does this content need to be updated somewhere else too?
Codecov Report
@@ Coverage Diff @@
## master #424 +/- ##
==========================================
- Coverage 95.64% 95.64% -0.01%
==========================================
Files 41 41
Lines 2297 2296 -1
==========================================
- Hits 2197 2196 -1
Misses 100 100
Continue to review full report at Codecov.
|
| io.StringIO(gzip.GzipFile(fileobj=io.BytesIO( | ||
| mtx_output.read("test.mtx/features.tsv.gz"))).read().decode()), | ||
| delimiter='\t', | ||
| fieldnames=["featurekey", |
There was a problem hiding this comment.
Required since features.tsv.gz per specification does not include headers. Will this be confusing to users given we're removing genes.tsv.gz?
|
Closing until #425 is resolved. |
No description provided.