-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LEAP-1792: Prevent empty tooltip for ControlButton #7083
base: develop
Are you sure you want to change the base?
Conversation
Refactored tooltip rendering logic in ControlButton to avoid wrapping buttons with empty tooltips. Introduced a constant for the empty submit tooltip message to improve code clarity and consistency.
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
/git merge develop
|
/git merge
|
@@ -41,23 +41,31 @@ type ControlButtonProps = { | |||
onClick: (e: React.MouseEvent) => void; | |||
}; | |||
|
|||
export const EMPTY_SUBMIT_TOOLTIP = "Empty annotations denied in this project"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor note here - certainly non-blocking - but i see we're exporting it but we dont use it outside of this file
export const EMPTY_SUBMIT_TOOLTIP = "Empty annotations denied in this project"; | |
const EMPTY_SUBMIT_TOOLTIP = "Empty annotations denied in this project"; |
/git merge
|
Refactored tooltip rendering logic in the ControlButton to avoid wrapping buttons with empty tooltips. Introduced a constant for the empty tooltip message to improve code clarity and consistency.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
Empty tooltips on the custom controls.
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)