124 add functions in the contracts that allow minstake and mindelegation to be changeable by the governor #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SamBorisov
commented
Apr 30, 2024
SamBorisov
commented
- Add an external function in RewardPool changeMinDelegation, that is callable only by the default_admin_role (governance)
- A private function that handles the logic for changing minDelegation and is used on initializing
- Add new custom error - InvalidMinDelegation
- Add an external function in RewardPool changeMinStake, that is callable only by the owner (governance)
- A private function that handles the logic for changing minStake and is used on initializing
- Apply needed updates on Interfaces
- Add tests to see if functions work
- Fix RewardPool initializing with system address, not governance on tests. Apply needed changes so it all works well.
R-Santev
requested changes
May 7, 2024
R-Santev
requested changes
May 8, 2024
| @@ -8,5 +8,5 @@ error InvalidSignature(address signer); | |||
| error ZeroAddress(); | |||
| error SendFailed(); | |||
| error InvalidCommission(uint256 commission); | |||
| error InvalidMinStake(uint256 minStake); | |||
There was a problem hiding this comment.
This file is used for common errors that are resued in more than one module. Declare module specific errors in the module itself.
There was a problem hiding this comment.
Moved errors for minStake/minDelegetion and commission
R-Santev
requested changes
May 9, 2024
R-Santev
approved these changes
May 10, 2024
R-Santev
approved these changes
May 10, 2024
SamBorisov
force-pushed
the
124-add-functions-in-the-contracts-that-allow-minstake-and-mindelegation-to-be-changeable-by-the-governor
branch
from
4af14fb to
068e07b
Compare
SamBorisov
deleted the
124-add-functions-in-the-contracts-that-allow-minstake-and-mindelegation-to-be-changeable-by-the-governor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.